From: Toru Komatsu <k0ma@utam0k.jp>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] .gitignore: Add compilation database files
Date: Wed, 24 Jul 2019 01:28:40 +0900 [thread overview]
Message-ID: <20190723162840.GA7110@gmail.com> (raw)
In-Reply-To: <CAK7LNARBjkYHkmv1michYYMd-2_70d+-Gvg1Kv4FyPeeBShvdw@mail.gmail.com>
On 07/24, Masahiro Yamada wrote:
> Just a nit.
>
> The patch title is:
> .gitignore: Add compilation database "files"
>
> Maybe, should it be singular?
>
>
> On Sun, Jul 21, 2019 at 5:55 PM Toru Komatsu <k0ma@utam0k.jp> wrote:
> >
> > This file is used by clangd to use language server protocol.
> > It can be generated at each compile using scripts/gen_compile_commands.py.
> > Therefore it is different depending on the environment and should be
> > ignored.
> >
> > Signed-off-by: Toru Komatsu <k0ma@utam0k.jp>
> > ---
> > .gitignore | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 8f5422cba6e2..025d887f64f1 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -142,3 +142,6 @@ x509.genkey
> >
> > # Kdevelop4
> > *.kdev4
> > +
> > +# Clang's compilation database files
> > +/compile_commands.json
> > --
> > 2.17.1
> >
>
>
> --
> Best Regards
> Masahiro Yamada
--
Thanks for your review.
Sorry, this point which you pointed out is my mistake.
It is should be "file".
I'm begginer because this patch is my first time,
What should I do next?
> Thanks,
> ~Toru Komatsu
next prev parent reply other threads:[~2019-07-23 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 8:54 Toru Komatsu
2019-07-22 19:25 ` Nick Desaulniers
2019-07-23 15:33 ` Masahiro Yamada
2019-07-23 16:28 ` Toru Komatsu [this message]
2019-07-23 16:36 ` Masahiro Yamada
2019-07-23 19:46 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723162840.GA7110@gmail.com \
--to=k0ma@utam0k.jp \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®