From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: aelior@marvell.com, GR-everest-linux-l2@marvell.com,
Yuval.Mintz@qlogic.com, manishc@marvell.com,
michal.kalderon@marvell.com, skalluru@marvell.com,
denis.bolotin@cavium.com, rverma@marvell.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH net-next] qed: reduce maximum stack frame size
Date: Wed, 24 Jul 2019 15:46:25 -0700 (PDT) [thread overview]
Message-ID: <20190724.154625.790572941356692025.davem@davemloft.net> (raw)
In-Reply-To: <20190722150133.1157096-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 22 Jul 2019 17:01:23 +0200
> clang warns about an overly large stack frame in one function
> when it decides to inline all __qed_get_vport_*() functions into
> __qed_get_vport_stats():
>
> drivers/net/ethernet/qlogic/qed/qed_l2.c:1889:13: error: stack frame size of 1128 bytes in function '_qed_get_vport_stats' [-Werror,-Wframe-larger-than=]
>
> Use a noinline_for_stack annotation to prevent clang from inlining
> these, which keeps the maximum stack usage at around half of that
> in the worst case, similar to what we get with gcc.
>
> Fixes: 86622ee75312 ("qed: Move statistics to L2 code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to net-next.
prev parent reply other threads:[~2019-07-24 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 15:01 Arnd Bergmann
2019-07-24 22:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724.154625.790572941356692025.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=GR-everest-linux-l2@marvell.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=aelior@marvell.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=denis.bolotin@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=michal.kalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rverma@marvell.com \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®