From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548ACC76191 for ; Fri, 26 Jul 2019 05:40:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E6A322C7C for ; Fri, 26 Jul 2019 05:40:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="GO+MZCCs"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GpbeM8O5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbfGZFkI (ORCPT ); Fri, 26 Jul 2019 01:40:08 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:47191 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbfGZFkH (ORCPT ); Fri, 26 Jul 2019 01:40:07 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id E97594043; Fri, 26 Jul 2019 01:40:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 26 Jul 2019 01:40:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm3; bh=YmS6AsD+8CfqKBI7XO37yB9Lqp cZsRZIp6cXhLrnCAQ=; b=GO+MZCCs151Sya5IlFCRgSqjgopJaNvo+2TLp+7e6X JGiOodAVbNOf2PEqYxOV+3zZ1uPvz9hXsigCtIZqmFSOWFz6hvycSPs4hLkUisxh A0KY7HE12NdClt4IlqianUaPtZhgQXpohciMYjwjb+GmHh3IojkHdS0OZOqmKsKL TkwDwY5rsbDT0oPmGfiO+ghu1ltEVFxP6VfDf2W6Wz1shXGVpB3Uk9sIfEx3GfWQ S2G5V3uKoNirAwbT0OojSvuck1nLQ8bnuSz12NggOcTMDuA7jZ4SUxviMsAtYVei 9OSwI8VS47fpU28hYPB4HNzZUcc6wkO1iN4BCn9ftoxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=YmS6AsD+8CfqKBI7X O37yB9LqpcZsRZIp6cXhLrnCAQ=; b=GpbeM8O5L9VE83JmuX0dO0mIycwgG8+Zk 528mLzTW9p4b1O4QpN1MLKBBOgPz6JtsXyCd6iPR+dgT3zVDDLQ6L+rBeFFsFMyC MR9bk+cb/ooiI4UHm3rGbeZraT1m86+CxvjXltEQTeeWppus2rnNBzebIeSk0+us iZmsMwpf0bKank7PUl5sNmBaF6Nu381uXAXFoq6EoXM5rsk4RKsvUPwJIThJ7cwn jI1/WbUuCuHXM9mBFoJyU2h2iPEUKwwp/Shnwlm1xODyBryDngT9W8IxEOMd9N2g H21k/gLQDWdXqCMxTkA7Wms3Bp22cuORWyypb14DM7XFDQ57GLHIw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrkeefgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertdertd dtnecuhfhrohhmpeetnhgurhgvficulfgvfhhfvghrhicuoegrnhgurhgvfiesrghjrdhi ugdrrghuqeenucfkphepvddtvddrkedurddukedrfedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegrnhgurhgvfiesrghjrdhiugdrrghunecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mistburn.au.ibm.com (bh02i525f01.au.ibm.com [202.81.18.30]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A89F380079; Fri, 26 Jul 2019 01:39:53 -0400 (EDT) From: Andrew Jeffery To: linux-aspeed@lists.ozlabs.org Cc: Andrew Jeffery , robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, anoo@us.ibm.com, a.filippov@yadro.com, arnd@arndb.de, yang.brianc.w@inventec.com, minyard@acm.org, gregkh@linuxfoundation.org, haiyue.wang@linux.intel.com, wangzqbj@inspur.com, chen.kenyy@inventec.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, openipmi-developer@lists.sourceforge.net, venture@google.com, sschaeck@cisco.com, taoren@fb.com, xow@google.com, yao.yuan@linaro.org Subject: [RFC-ish PATCH 00/17] Clean up ASPEED devicetree warnings Date: Fri, 26 Jul 2019 15:09:42 +0930 Message-Id: <20190726053959.2003-1-andrew@aj.id.au> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, The aim of this series is to minimise/eliminate all the warnings from the ASPEED devicetrees. It mostly achieves its goal, as outlined below. Using `aspeed_g5_defconfig` we started with the follow warning count: $ make dtbs 2>&1 >/dev/null | wc -l 218 and after the full series is applied we have: $ make dtbs 2>&1 >/dev/null | wc -l 2 for a 100x reduction. Getting there though isn't without some potential controversy, which I've saved for the last half of the series. The following patches I think are in pretty good shape: ARM: dts: aspeed-g5: Move EDAC node to APB ARM: dts: aspeed-g5: Use recommended generic node name for SDMC ARM: dts: aspeed-g5: Fix aspeed,external-nodes description ARM: dts: vesnin: Add unit address for memory node ARM: dts: fp5280g2: Cleanup gpio-keys-polled properties ARM: dts: swift: Cleanup gpio-keys-polled properties ARM: dts: witherspoon: Cleanup gpio-keys-polled properties ARM: dts: aspeed: Cleanup lpc-ctrl and snoop regs ARM: dts: ibm-power9-dual: Add a unit address for OCC nodes With these patches applied we get to: $ make dtbs 2>&1 >/dev/null | wc -l 144 So they make a dent, but fail to clean up the bulk of the issues. From here I've mixed in some binding and driver changes with subsequent updates to the devicetrees: dt-bindings: pinctrl: aspeed: Add reg property as a hint dt-bindings: misc: Document reg for aspeed,p2a-ctrl nodes ARM: dts: aspeed: Add reg hints to syscon children dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS ipmi: kcs: Finish configuring ASPEED KCS device before enable ipmi: kcs: aspeed: Implement v2 bindings ARM: dts: aspeed-g5: Change KCS nodes to v2 binding ARM: dts: aspeed-g5: Sort LPC child nodes by unit address By `dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS` the warnings are reduced to: $ make dtbs 2>&1 >/dev/null | wc -l 125 The bang-for-buck is in fixing up the KCS bindings which removes all-but-two of the remaining warnings (which we can't feasibly remove), but doing so forces code changes (which I'd avoided up until this point). Reflecting broadly on the fixes, I think I've made a mistake way back by using syscon/simple-mfds to expose the innards of the SCU and LPC controllers in the devicetree. This series cleans up what's currently there, but I have half a mind to rev the SCU and LPC bindings to not use simple-mfd and instead have a driver implementation that uses `platform_device_register_full()` or similar to deal with the mess. Rob - I'm looking for your thoughts here and on the series, I've never felt entirely comfortable with what I cooked up. Your advice would be appreciated. Anyway, everyone, please let me know your thoughts on the bits relevant to you. If we can agree on a way forward I'll split up the series for subsequent submissions so it isn't such a spam-fest. Cheers, Andrew Andrew Jeffery (17): ARM: dts: aspeed-g5: Move EDAC node to APB ARM: dts: aspeed-g5: Use recommended generic node name for SDMC ARM: dts: aspeed-g5: Fix aspeed,external-nodes description ARM: dts: vesnin: Add unit address for memory node ARM: dts: fp5280g2: Cleanup gpio-keys-polled properties ARM: dts: swift: Cleanup gpio-keys-polled properties ARM: dts: witherspoon: Cleanup gpio-keys-polled properties ARM: dts: aspeed: Cleanup lpc-ctrl and snoop regs ARM: dts: ibm-power9-dual: Add a unit address for OCC nodes dt-bindings: pinctrl: aspeed: Add reg property as a hint dt-bindings: misc: Document reg for aspeed,p2a-ctrl nodes ARM: dts: aspeed: Add reg hints to syscon children dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS ipmi: kcs: Finish configuring ASPEED KCS device before enable ipmi: kcs: aspeed: Implement v2 bindings ARM: dts: aspeed-g5: Change KCS nodes to v2 binding ARM: dts: aspeed-g5: Sort LPC child nodes by unit address .../bindings/ipmi/aspeed-kcs-bmc.txt | 20 ++- .../bindings/misc/aspeed-p2a-ctrl.txt | 1 + .../pinctrl/aspeed,ast2400-pinctrl.yaml | 3 + .../pinctrl/aspeed,ast2500-pinctrl.yaml | 3 + .../dts/aspeed-bmc-arm-centriq2400-rep.dts | 4 - .../aspeed-bmc-arm-stardragon4800-rep2.dts | 4 - arch/arm/boot/dts/aspeed-bmc-facebook-cmm.dts | 4 - .../arm/boot/dts/aspeed-bmc-facebook-yamp.dts | 4 - .../boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 6 - .../arm/boot/dts/aspeed-bmc-intel-s2600wf.dts | 4 - arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts | 4 - arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 4 - arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 6 - arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts | 2 +- .../boot/dts/aspeed-bmc-opp-witherspoon.dts | 6 - arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 2 - arch/arm/boot/dts/aspeed-g4.dtsi | 21 ++- arch/arm/boot/dts/aspeed-g5.dtsi | 73 ++++---- arch/arm/boot/dts/ibm-power9-dual.dtsi | 4 +- drivers/char/ipmi/kcs_bmc_aspeed.c | 163 ++++++++++++++---- 20 files changed, 205 insertions(+), 133 deletions(-) -- 2.20.1