From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>
Cc: Luca Abeni <luca.abeni@santannapisa.it>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <Valentin.Schneider@arm.com>,
Qais Yousef <Qais.Yousef@arm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] sched/deadline: Remove unused int flags from __dequeue_task_dl()
Date: Fri, 26 Jul 2019 09:27:53 +0100 [thread overview]
Message-ID: <20190726082756.5525-3-dietmar.eggemann@arm.com> (raw)
In-Reply-To: <20190726082756.5525-1-dietmar.eggemann@arm.com>
The int flags parameter is not used in __dequeue_task_dl(). Remove it.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
---
kernel/sched/deadline.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index d1aeada374e1..99d4c24a8637 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -637,7 +637,7 @@ static inline void deadline_queue_pull_task(struct rq *rq)
#endif /* CONFIG_SMP */
static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags);
-static void __dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags);
+static void __dequeue_task_dl(struct rq *rq, struct task_struct *p);
static void check_preempt_curr_dl(struct rq *rq, struct task_struct *p, int flags);
/*
@@ -1245,7 +1245,7 @@ static void update_curr_dl(struct rq *rq)
(dl_se->flags & SCHED_FLAG_DL_OVERRUN))
dl_se->dl_overrun = 1;
- __dequeue_task_dl(rq, curr, 0);
+ __dequeue_task_dl(rq, curr);
if (unlikely(dl_se->dl_boosted || !start_dl_timer(curr)))
enqueue_task_dl(rq, curr, ENQUEUE_REPLENISH);
@@ -1535,7 +1535,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
enqueue_pushable_dl_task(rq, p);
}
-static void __dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
+static void __dequeue_task_dl(struct rq *rq, struct task_struct *p)
{
dequeue_dl_entity(&p->dl);
dequeue_pushable_dl_task(rq, p);
@@ -1544,7 +1544,7 @@ static void __dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
static void dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
{
update_curr_dl(rq);
- __dequeue_task_dl(rq, p, flags);
+ __dequeue_task_dl(rq, p);
if (p->on_rq == TASK_ON_RQ_MIGRATING || flags & DEQUEUE_SAVE) {
sub_running_bw(&p->dl, &rq->dl);
--
2.17.1
next prev parent reply other threads:[~2019-07-26 8:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 8:27 [PATCH 0/5] sched/deadline: Fix double accounting in push_dl_task() & some cleanups Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 1/5] sched/deadline: Fix double accounting of rq/running bw in push_dl_task() Dietmar Eggemann
2019-07-26 10:11 ` luca abeni
2019-07-29 8:59 ` Dietmar Eggemann
2019-07-29 16:10 ` Peter Zijlstra
2019-07-26 13:30 ` luca abeni
2019-07-29 9:00 ` Dietmar Eggemann
2019-07-31 10:32 ` Dietmar Eggemann
2019-07-26 8:27 ` Dietmar Eggemann [this message]
2019-07-29 16:35 ` [PATCH 2/5] sched/deadline: Remove unused int flags from __dequeue_task_dl() Peter Zijlstra
2019-07-29 17:12 ` Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 3/5] sched/deadline: Use __sub_running_bw() throughout dl_change_utilization() Dietmar Eggemann
2019-07-29 16:47 ` Peter Zijlstra
2019-07-29 17:21 ` Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 4/5] sched/deadline: Cleanup on_dl_rq() handling Dietmar Eggemann
2019-07-26 8:37 ` Valentin Schneider
2019-07-26 8:58 ` Qais Yousef
2019-07-26 9:20 ` Juri Lelli
2019-07-26 9:32 ` Valentin Schneider
2019-07-29 16:49 ` Peter Zijlstra
2019-07-30 6:41 ` Juri Lelli
2019-07-30 8:21 ` Peter Zijlstra
2019-07-31 17:32 ` Dietmar Eggemann
2019-07-31 20:20 ` luca abeni
2019-08-01 16:01 ` Dietmar Eggemann
2019-07-26 8:27 ` [PATCH 5/5] sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting Dietmar Eggemann
2019-07-26 10:18 ` luca abeni
2019-07-29 16:54 ` Peter Zijlstra
2019-07-29 16:59 ` Dietmar Eggemann
2019-07-30 8:23 ` Peter Zijlstra
2019-07-30 16:08 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726082756.5525-3-dietmar.eggemann@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=Qais.Yousef@arm.com \
--cc=Valentin.Schneider@arm.com \
--cc=bristot@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®