From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Chen-Yu Tsai <wens@csie.org>
Cc: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Subject: Re: [PATCH v1 1/2] extcon: axp288: Add missed error check
Date: Fri, 26 Jul 2019 15:12:07 +0300 [thread overview]
Message-ID: <20190726121207.GU9224@smile.fi.intel.com> (raw)
In-Reply-To: <bf2b9870-8504-17da-50b8-b1414b7d9b39@samsung.com>
On Fri, Jul 26, 2019 at 10:15:30AM +0900, Chanwoo Choi wrote:
> On 19. 7. 26. 오전 5:34, Andy Shevchenko wrote:
> > It seems from the very beginning the error check has been missed
> > in axp288_extcon_log_rsi(). Add it here.
> > ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
> > + if (ret < 0)
> > + return;
>
> It need to print error log because axp288_extcon_log_rsi() has the void'
> return type if there is no any error log, it is not possible to check
> the error status.
Makes sense.
Will add in v2.
P.S. You answered privately, I had returned Cc list back.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-07-26 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190725203413epcas5p115dbc8d8119e17e39c38e5fb847d3ac5@epcas5p1.samsung.com>
2019-07-25 20:34 ` Andy Shevchenko
2019-07-25 20:34 ` [PATCH v1 2/2] extcon: axp288: Use for_each_set_bit() in axp288_extcon_log_rsi() Andy Shevchenko
2019-07-26 2:20 ` Chanwoo Choi
[not found] ` <bf2b9870-8504-17da-50b8-b1414b7d9b39@samsung.com>
2019-07-26 12:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726121207.GU9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome