From: Sam Ravnborg <sam@ravnborg.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Purism Kernel Team <kernel@puri.sm>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] drm/panel: jh057n00900: Move dsi init sequence to prepare
Date: Fri, 26 Jul 2019 20:43:06 +0200 [thread overview]
Message-ID: <20190726184306.GA14981@ravnborg.org> (raw)
In-Reply-To: <cover.1564146727.git.agx@sigxcpu.org>
Hi Guido.
On Fri, Jul 26, 2019 at 03:14:35PM +0200, Guido Günther wrote:
>
> If the panel is wrapped in a panel_bridge it gets prepar()ed before the
> upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks
> are not enabled yet). To avoid this move the panel's first DSI access to
> enable() so the upstream bridge can prepare the DSI host controller in
> it's pre_enable().
>
> The second patch makes the disable() call symmetric to the above and the third
> one just eases debugging.
>
> Changes from v1:
> * As per review comments by Sam Ravnborg
> * Ignore failures to disable the backlight in jh057n_disable()
> * Add 'drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently'
> * Collected Reviewed-By: Thanks Sam!
>
> To: "Guido Günther" <agx@sigxcpu.org>,Purism Kernel Team <kernel@puri.sm>,Thierry Reding <thierry.reding@gmail.com>,Sam Ravnborg <sam@ravnborg.org>,David Airlie <airlied@linux.ie>,Daniel Vetter <daniel@ffwll.ch>,dri-devel@lists.freedesktop.org,linux-kernel@vger.kernel.org
>
>
> Guido Günther (4):
> drm/panel: jh057n00900: Move panel DSI init to enable()
> drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable()
> drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s
> drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently
Looks good. Series applied to drm-misc-next and pushed out.
Sam
prev parent reply other threads:[~2019-07-26 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 13:14 Guido Günther
2019-07-26 13:14 ` [PATCH v2 1/4] drm/panel: jh057n00900: Move panel DSI init to enable() Guido Günther
2019-07-26 13:14 ` [PATCH v2 2/4] drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable() Guido Günther
2019-07-26 13:14 ` [PATCH v2 3/4] drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s Guido Günther
2019-07-26 13:14 ` [PATCH v2 4/4] drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently Guido Günther
2019-07-26 18:43 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726184306.GA14981@ravnborg.org \
--to=sam@ravnborg.org \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome