From: Scott Wood <swood@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Scott Wood <swood@redhat.com>
Subject: [PATCH RT 4/8] sched: migrate disable: Protect cpus_ptr with lock
Date: Sat, 27 Jul 2019 00:56:34 -0500 [thread overview]
Message-ID: <20190727055638.20443-5-swood@redhat.com> (raw)
In-Reply-To: <20190727055638.20443-1-swood@redhat.com>
Various places assume that cpus_ptr is protected by rq/pi locks,
so don't change it before grabbing those locks.
Signed-off-by: Scott Wood <swood@redhat.com>
---
kernel/sched/core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 99a3cfccf4d3..38a9a9df5638 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7283,9 +7283,8 @@ void dump_cpu_task(int cpu)
struct rq *rq;
struct rq_flags rf;
- p->cpus_ptr = cpumask_of(smp_processor_id());
-
rq = task_rq_lock(p, &rf);
+ p->cpus_ptr = cpumask_of(smp_processor_id());
update_nr_migratory(p, -1);
p->nr_cpus_allowed = 1;
task_rq_unlock(rq, p, &rf);
@@ -7297,9 +7296,8 @@ void dump_cpu_task(int cpu)
struct rq *rq;
struct rq_flags rf;
- p->cpus_ptr = &p->cpus_mask;
-
rq = task_rq_lock(p, &rf);
+ p->cpus_ptr = &p->cpus_mask;
p->nr_cpus_allowed = cpumask_weight(&p->cpus_mask);
update_nr_migratory(p, 1);
task_rq_unlock(rq, p, &rf);
--
1.8.3.1
next prev parent reply other threads:[~2019-07-27 5:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 5:56 [RT PATCH 0/8] migrate disable fixes and performance Scott Wood
2019-07-27 5:56 ` [PATCH RT 1/8] sched: migrate_enable: Use sleeping_lock to indicate involuntary sleep Scott Wood
2019-07-29 13:26 ` Steven Rostedt
2019-07-27 5:56 ` [PATCH RT 2/8] sched: __set_cpus_allowed_ptr: Check cpus_mask, not cpus_ptr Scott Wood
2019-09-17 14:57 ` Sebastian Andrzej Siewior
2019-09-17 15:23 ` Scott Wood
2019-07-27 5:56 ` [PATCH RT 3/8] sched: Remove dead __migrate_disabled() check Scott Wood
2019-07-27 5:56 ` Scott Wood [this message]
2019-09-26 16:39 ` [PATCH RT 4/8] sched: migrate disable: Protect cpus_ptr with lock Sebastian Andrzej Siewior
2019-09-26 16:52 ` Scott Wood
2019-09-27 12:19 ` Sebastian Andrzej Siewior
2019-09-27 20:02 ` Scott Wood
2019-07-27 5:56 ` [PATCH RT 5/8] sched/deadline: Reclaim cpuset bandwidth in .migrate_task_rq() Scott Wood
2019-09-17 15:10 ` Sebastian Andrzej Siewior
2019-09-27 8:11 ` Juri Lelli
2019-09-27 16:40 ` Scott Wood
2019-09-30 7:12 ` Juri Lelli
2019-09-30 16:24 ` Scott Wood
2019-10-01 8:52 ` Juri Lelli
2019-10-09 6:25 ` Scott Wood
2019-10-09 7:27 ` Juri Lelli
2019-10-09 19:12 ` Scott Wood
2019-10-10 8:18 ` Juri Lelli
2019-07-27 5:56 ` [PATCH RT 6/8] sched: migrate_enable: Set state to TASK_RUNNING Scott Wood
2019-09-17 15:31 ` Sebastian Andrzej Siewior
2019-09-17 17:54 ` Scott Wood
2019-07-27 5:56 ` [PATCH RT 7/8] sched: migrate_enable: Use select_fallback_rq() Scott Wood
2019-09-17 16:00 ` Sebastian Andrzej Siewior
2019-09-24 18:05 ` Scott Wood
2019-07-27 5:56 ` [PATCH RT 8/8] sched: Lazy migrate_disable processing Scott Wood
2019-09-17 16:50 ` Sebastian Andrzej Siewior
2019-09-17 17:06 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190727055638.20443-5-swood@redhat.com \
--to=swood@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®