From: Matteo Croce <mcroce@redhat.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] arm_pmu: mark expected switch fall-through
Date: Mon, 29 Jul 2019 01:53:20 +0200 [thread overview]
Message-ID: <20190728235320.8600-1-mcroce@redhat.com> (raw)
Mark switch cases where we are expecting to fall through,
fixes the following warning:
drivers/perf/arm_pmu.c: In function ‘cpu_pm_pmu_notify’:
drivers/perf/arm_pmu.c:726:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
cpu_pm_pmu_setup(armpmu, cmd);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/perf/arm_pmu.c:727:2: note: here
case CPU_PM_ENTER_FAILED:
^~~~
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
drivers/perf/arm_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 2d06b8095a19..3eb711066a22 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -724,6 +724,7 @@ static int cpu_pm_pmu_notify(struct notifier_block *b, unsigned long cmd,
break;
case CPU_PM_EXIT:
cpu_pm_pmu_setup(armpmu, cmd);
+ /* fallthrough */
case CPU_PM_ENTER_FAILED:
armpmu->start(armpmu);
break;
--
2.21.0
next reply other threads:[~2019-07-28 23:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 23:53 Matteo Croce [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-26 11:27 [PATCH] arm_pmu: Mark " Anders Roxell
2019-07-26 12:29 ` Mark Rutland
2019-07-26 13:06 ` Will Deacon
2019-07-26 15:18 ` Lorenzo Pieralisi
2019-07-30 11:24 ` Mark Rutland
2019-07-30 11:27 ` Will Deacon
2019-07-30 11:42 ` Mark Rutland
2019-07-30 12:30 ` Anders Roxell
2019-07-30 12:43 ` Will Deacon
2019-07-30 15:21 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728235320.8600-1-mcroce@redhat.com \
--to=mcroce@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®