mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuhong Yuan <hslester96@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, Chuhong Yuan <hslester96@gmail.com>
Subject: [PATCH 10/12] sched: Replace strncmp with str_has_prefix
Date: Mon, 29 Jul 2019 23:15:21 +0800	[thread overview]
Message-ID: <20190729151521.9768-1-hslester96@gmail.com> (raw)

strncmp(str, const, len) is error-prone.
We had better use newly introduced
str_has_prefix() instead of it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 kernel/sched/debug.c     | 2 +-
 kernel/sched/isolation.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index f7e4579e746c..6a77bf51e4d3 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -103,7 +103,7 @@ static int sched_feat_set(char *cmp)
 	int i;
 	int neg = 0;
 
-	if (strncmp(cmp, "NO_", 3) == 0) {
+	if (str_has_prefix(cmp, "NO_")) {
 		neg = 1;
 		cmp += 3;
 	}
diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c
index ccb28085b114..cd5dfa93095d 100644
--- a/kernel/sched/isolation.c
+++ b/kernel/sched/isolation.c
@@ -143,13 +143,13 @@ static int __init housekeeping_isolcpus_setup(char *str)
 	unsigned int flags = 0;
 
 	while (isalpha(*str)) {
-		if (!strncmp(str, "nohz,", 5)) {
+		if (str_has_prefix(str, "nohz,")) {
 			str += 5;
 			flags |= HK_FLAG_TICK;
 			continue;
 		}
 
-		if (!strncmp(str, "domain,", 7)) {
+		if (str_has_prefix(str, "domain,")) {
 			str += 7;
 			flags |= HK_FLAG_DOMAIN;
 			continue;
-- 
2.20.1


                 reply	other threads:[~2019-07-29 15:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729151521.9768-1-hslester96@gmail.com \
    --to=hslester96@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®