From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12892C433FF for ; Tue, 30 Jul 2019 08:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCE052087F for ; Tue, 30 Jul 2019 08:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564474461; bh=ag7RLjHCXMfUGjpSus0nvTkEpPZCaEx3QNbC7mm6+N4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=a8IcucQpVC89ZXcYi4tunYe+B2DbXy/JuLgMfsuHghRdPXMUjpE9ZUUHPmo2gHt+p Dx1p/8Ac6AMmo+Ln57yiVuxejWb53uD3ZlZGDCPPtvf+G01dsSGu/QveiU1mEgrrd5 thv+P2nSCBgGojRndJ6enH0cMw94TazH7dYcGPSo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbfG3IOU (ORCPT ); Tue, 30 Jul 2019 04:14:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:36754 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726535AbfG3IOU (ORCPT ); Tue, 30 Jul 2019 04:14:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 59F32ABE9; Tue, 30 Jul 2019 08:14:18 +0000 (UTC) Date: Tue, 30 Jul 2019 10:14:15 +0200 From: Michal Hocko To: Hoan Tran OS Cc: Will Deacon , Catalin Marinas , Heiko Carstens , "open list:MEMORY MANAGEMENT" , Paul Mackerras , "H . Peter Anvin" , "sparclinux@vger.kernel.org" , Alexander Duyck , "linux-s390@vger.kernel.org" , Michael Ellerman , "x86@kernel.org" , Mike Rapoport , Christian Borntraeger , Ingo Molnar , Vlastimil Babka , Benjamin Herrenschmidt , Open Source Submission , Pavel Tatashin , Vasily Gorbik , Will Deacon , Borislav Petkov , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Oscar Salvador , "linux-kernel@vger.kernel.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S . Miller" , "willy@infradead.org" Subject: Re: [PATCH v2 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Message-ID: <20190730081415.GN9330@dhcp22.suse.cz> References: <1562887528-5896-1-git-send-email-Hoan@os.amperecomputing.com> <20190712070247.GM29483@dhcp22.suse.cz> <586ae736-a429-cf94-1520-1a94ffadad88@os.amperecomputing.com> <20190712121223.GR29483@dhcp22.suse.cz> <20190712143730.au3662g4ua2tjudu@willie-the-truck> <20190712150007.GU29483@dhcp22.suse.cz> <730368c5-1711-89ae-e3ef-65418b17ddc9@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <730368c5-1711-89ae-e3ef-65418b17ddc9@os.amperecomputing.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Sorry for a late reply] On Mon 15-07-19 17:55:07, Hoan Tran OS wrote: > Hi, > > On 7/12/19 10:00 PM, Michal Hocko wrote: [...] > > Hmm, I thought this was selectable. But I am obviously wrong here. > > Looking more closely, it seems that this is indeed only about > > __early_pfn_to_nid and as such not something that should add a config > > symbol. This should have been called out in the changelog though. > > Yes, do you have any other comments about my patch? Not really. Just make sure to explicitly state that CONFIG_NODES_SPAN_OTHER_NODES is only about __early_pfn_to_nid and that doesn't really deserve it's own config and can be pulled under NUMA. > > Also while at it, does HAVE_MEMBLOCK_NODE_MAP fall into a similar > > bucket? Do we have any NUMA architecture that doesn't enable it? > > > > As I checked with arch Kconfig files, there are 2 architectures, riscv > and microblaze, do not support NUMA but enable this config. > > And 1 architecture, alpha, supports NUMA but does not enable this config. Care to have a look and clean this up please? -- Michal Hocko SUSE Labs