From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEE7C433FF for ; Tue, 30 Jul 2019 04:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0AA8206B8 for ; Tue, 30 Jul 2019 04:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="vHr5CCoO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbfG3Ep2 (ORCPT ); Tue, 30 Jul 2019 00:45:28 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:33839 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbfG3Ep2 (ORCPT ); Tue, 30 Jul 2019 00:45:28 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45yPBG41FXz9s3Z; Tue, 30 Jul 2019 14:45:26 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1564461926; bh=jVD+AoMQGxi/wGGXONCIPWY+Ktwi9IFbSQiYXXW609I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vHr5CCoOOUOXhslZFa6FwTY+3WcjSvShnk5udQDMSTK8z4KTNI75mqtrzgVlNqIqg EkehG84POXKm5lST85lzzOB8G7CixJVfOofDlzVl7Pa0kDobAPIzwNARdaZupi1dVv 4FQ8nnr3MLRyJIqVEeqw6DUszojUsevZ6UH244LZHBlH2HmYWcoU4IRj4sA2+VyC8h 0uh0j77wVTCixZJ9mI6mindrSXaDSi/7JcU9/XBZ21ycqVVIdMFBqr1uFcZ05KN2fg p4mS2zxvWchv0nNAMNxFuWEm2q6wrbg/iBbMLdWpAiEr66fll6T9rdNnO/2Ij5F87i X21VklLnoF41A== Date: Tue, 30 Jul 2019 14:45:26 +1000 From: Stephen Rothwell To: Benjamin Herrenschmidt , Michael Ellerman Cc: PowerPC , "Gustavo A. R. Silva" , Kees Cook , Linux kernel Mailing List Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through Message-ID: <20190730144526.3088aad4@canb.auug.org.au> In-Reply-To: <20190730143704.060a2606@canb.auug.org.au> References: <20190730143704.060a2606@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/CPhGrAmmSmh99vXtb+BIRHN"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/CPhGrAmmSmh99vXtb+BIRHN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Tue, 30 Jul 2019 14:37:04 +1000 Stephen Rothwell = wrote: > > Mark switch cases where we are expecting to fall through. >=20 > This patch fixes the following warning (Building: powerpc): >=20 > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning: this statement may fall through = [-Wimplicit-fallthrough=3D] > cmd->info.devaddr &=3D 0xfe; > ~~~~~~~~~~~~~~~~~~^~~~~~~ > drivers/macintosh/smu.c:855:2: note: here > case SMU_I2C_TRANSFER_STDSUB: > ^~~~ >=20 > Cc: Benjamin Herrenschmidt > Cc: Gustavo A. R. Silva > Cc: Kees Cook > Signed-off-by: Stephen Rothwell Fixes: 0365ba7fb1fa ("[PATCH] ppc64: SMU driver update & i2c support") Sorry, forgot :-) --=20 Cheers, Stephen Rothwell --Sig_/CPhGrAmmSmh99vXtb+BIRHN Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl0/y2YACgkQAVBC80lX 0Gyt0wgAi3jthifR+t5hLJW4sbfr3P+HukPfwX1FebITb+a65Uu+7K8zNV9n6g1J MsmihdRnaaO2rD+YLCnqSBDZjNdD1j5cXDcWQJe3nPM69nfblQyhNPbdyk48/q2b vT8OkvPfGvJelf73ph1gkkn6zXR3J3LAx9dpp3ittcSlLIsfhjlXz67IMDl8z8Bk ZxxFX8Rv2ivByxWDO4PGtxDFtAV3C/SlK6fzyIUvXBG5M+xPAe9Vy2UYRVY1ZekM l4c+3+dAXIod3G6SNBt2u/1NNn0xiXX0jPtkIw0j5n0fB3NQK2EmRpM32IKAcUYu XX55Y1BZxGJ01G7/eT0TNtVYJww9bQ== =7y4x -----END PGP SIGNATURE----- --Sig_/CPhGrAmmSmh99vXtb+BIRHN--