From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FA4C32751 for ; Wed, 31 Jul 2019 16:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CCE9206B8 for ; Wed, 31 Jul 2019 16:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbfGaQyF (ORCPT ); Wed, 31 Jul 2019 12:54:05 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:55740 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfGaQyF (ORCPT ); Wed, 31 Jul 2019 12:54:05 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id AF4D4FB03; Wed, 31 Jul 2019 18:54:02 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WqV7ea2juLfn; Wed, 31 Jul 2019 18:54:01 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 9B60D46D8A; Wed, 31 Jul 2019 18:54:00 +0200 (CEST) Date: Wed, 31 Jul 2019 18:54:00 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Fabio Estevam Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Lee Jones , DRI mailing list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Robert Chiras , Chris Healy Subject: Re: [PATCH 3/3] drm/bridge: Add NWL MIPI DSI host controller support Message-ID: <20190731165400.GA30745@bogon.m.sigxcpu.org> References: <3158f4f8c97c21f98c394e5631d74bc60d796522.1563983037.git.agx@sigxcpu.org> <20190731143532.GA1935@bogon.m.sigxcpu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jul 31, 2019 at 11:43:47AM -0300, Fabio Estevam wrote: > Hi Guido, > > On Wed, Jul 31, 2019 at 11:35 AM Guido Günther wrote: > > > The idea is to have > > > > "%sabling platform clocks", enable ? "en" : "dis"); > > > > depending whether clocks are enabled/disabled. > > Yes, I understood the idea, but this would print: > > ensabling or dissabling :-) The 's' is from the '%s' format specifier: [ 2610.804174] imx-nwl-dsi 30a00000.mipi_dsi: [drm:imx_nwl_dsi_bridge_disable] disabling platform clocks [ 2710.996279] imx-nwl-dsi 30a00000.mipi_dsi: [drm:imx_nwl_dsi_bridge_pre_enable] enabling platform clocks I'll change that to use the full strings though since i also had to look twice to be sure there's no double 's'. > > > > Same here. Please return 'int' instead. > > > > This is from drm_bridge_funcs so the prototype is fixed. I'm not sure > > how what's the best way to bubble up fatal errors through the drm layer? > > Ok, so let's not change this one. > > > I went for DRM_DEV_ERROR() since that what i used in the rest of the > > driver and these ones were omission. Hope that's o.k. > > No strong preferences here. I just think dev_err() easier to type and shorter. > > Thanks for this work! Thanks again for having a look! -- Guido