From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427C8C32751 for ; Wed, 31 Jul 2019 17:31:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19C9620C01 for ; Wed, 31 Jul 2019 17:31:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f/VCF9Kx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730781AbfGaRbp (ORCPT ); Wed, 31 Jul 2019 13:31:45 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:34320 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730765AbfGaRbm (ORCPT ); Wed, 31 Jul 2019 13:31:42 -0400 Received: by mail-pl1-f194.google.com with SMTP id i2so30805665plt.1; Wed, 31 Jul 2019 10:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jDqoJuUDc0pfMMhVm9i/41YEg5ZzqjvFPep6mT8qx0c=; b=f/VCF9KxnW7V9Se6378U6f/91XDcjDYiOM0+kriHKDCuzIaeupEcnYunBBtBA3XAPJ nNgh7laKu8NSU29snu8TlLCDbycZHY2WRpHv+cY6kgjxCXydp+SkpuNQ0nUGhc5cn6R5 d34ZNBP6NgHA0sDZiXy8Pd7S5zbthlxFg779SKFQbg7QIAyGtOZwGyWckisMFaF01Lk6 mRd3xRoWMPgHL48nvHupmPhW3obgomhGk8nvCwEv/DHzHz5vvrzrv0Q3tIreyTiuTP5O 2E4qwRzEoF+pq0MfjtWyqNOoZufId6w0FJaEMnH5sPVSYcESEjVOAvSOa5MTA1iod2nE /Jmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jDqoJuUDc0pfMMhVm9i/41YEg5ZzqjvFPep6mT8qx0c=; b=bbKmMlT+MjJjcjym5vx1YRf1wUadhLjM5oVVO8F+udz/5EqF/j2+dXK0kiJd5Vaqf4 lcDH4nC8DtZxaKZ4QGvqCKuQTwRvuP6g09lzqZbpbAVnLYXlyx6nlYfaPJPwVWH9jANU uiIjIg9lnz/kx4UvRyC5etZ8OGTYuK1bpLfoy+QxYei7i76tXBmPpfa8nnFhiz+qpRgH M44kiU7zKkmUdUVy4TFNxRZcxc8/9pMqY7v5S0b0t/G5qu9YgTWwg+t841B7x/EgT7vt MwYL73MSciN0NDAnD7T2kXL0a3jH5Q69eNxYS8zWgYu/RtkF8rlVRbR4GAPGOUpx2Goi mHDA== X-Gm-Message-State: APjAAAVr28q2ehVcudl0q23DEDRsjSHGxSwYvySbDNO/wX7yZlxFSR/p 6ENyrMO16nXqbCsTvsByKchcNbvWrBM= X-Google-Smtp-Source: APXvYqy08IupmUZhmzMcDU06KFjO3bRJSmYJWLt9Y3m0xctR1NTWwKEMpBE5JuBZTOMgqp+zEHkAPQ== X-Received: by 2002:a17:902:8489:: with SMTP id c9mr123055601plo.327.1564594300909; Wed, 31 Jul 2019 10:31:40 -0700 (PDT) Received: from localhost.localdomain ([2607:fb90:4ad:5a0b:2aff:6e0f:8973:5a26]) by smtp.gmail.com with ESMTPSA id bo20sm2089617pjb.23.2019.07.31.10.31.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 10:31:40 -0700 (PDT) From: Andrey Smirnov To: linux-serial@vger.kernel.org Cc: Andrey Smirnov , Stefan Agner , Chris Healy , Cory Tusar , Lucas Stach , Greg Kroah-Hartman , Jiri Slaby , linux-imx@nxp.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/23] tty: serial: fsl_lpuart: Drop unnecessary lpuart*_stop_tx() Date: Wed, 31 Jul 2019 10:30:38 -0700 Message-Id: <20190731173045.11718-17-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190731173045.11718-1-andrew.smirnov@gmail.com> References: <20190731173045.11718-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By the time lpuart_shutdown() calls lpuart_stop_tx() UARTCR2_TE and UARTCR2_TIE (which the latter will clear) are already cleared, so that function call should effectively be a no-op. Moreso, lpuart_stop_tx() is expected to be executed with port spinlock held, which the caller doesn't. Given all that, drop the call to lpuart_stop_tx() in lpuart_shutdown(). In case of lpuart32_shutdown()/lpuart32_stop_tx(), TIE won't even be set if lpuart_dma_tx_use is true. Drop it there as well. Signed-off-by: Andrey Smirnov Cc: Stefan Agner Cc: Chris Healy Cc: Cory Tusar Cc: Lucas Stach Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-imx@nxp.com Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/tty/serial/fsl_lpuart.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index e59dd90fc34c..2597a877d639 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1574,8 +1574,6 @@ static void lpuart_shutdown(struct uart_port *port) sport->dma_tx_in_progress = false; dmaengine_terminate_all(sport->dma_tx_chan); } - - lpuart_stop_tx(port); } } @@ -1607,8 +1605,6 @@ static void lpuart32_shutdown(struct uart_port *port) sport->dma_tx_in_progress = false; dmaengine_terminate_all(sport->dma_tx_chan); } - - lpuart32_stop_tx(port); } } -- 2.21.0