From: Guenter Roeck <linux@roeck-us.net>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-watchdog@vger.kernel.org, Chris Healy <cphealy@gmail.com>,
Rick Ramstetter <rick@anteaterllc.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Ziirave_wdt driver fixes
Date: Wed, 31 Jul 2019 11:11:27 -0700 [thread overview]
Message-ID: <20190731181127.GB3885@roeck-us.net> (raw)
In-Reply-To: <20190731174252.18041-1-andrew.smirnov@gmail.com>
On Wed, Jul 31, 2019 at 10:42:47AM -0700, Andrey Smirnov wrote:
> Everyone,
>
> This series contains various fixes/improvements for ziirave_wdt
> driver. Hopefully each commit is self-explanatory.
>
> Feedback is welcome!
>
> Thanks,
> Andrey Smirnov
>
> Andrey Smirnov (5):
> watchdog: ziirave_wdt: Add missing newline
> watchdog: ziirave_wdt: Be verbose about errors in probe()
> watchdog: ziirave_wdt: Be more verbose during firmware update
> watchdog: ziirave_wdt: Don't bail out on unexpected timeout value
> watchdog: ziirave_wdt: Log bootloader/firmware info during probe
Since you are touching the driver, I would suggest another change:
Use devm_watchdog_register_device() and drop the remove function.
Guenter
prev parent reply other threads:[~2019-07-31 18:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 17:42 Andrey Smirnov
2019-07-31 17:42 ` [PATCH 1/5] watchdog: ziirave_wdt: Add missing newline Andrey Smirnov
2019-07-31 21:42 ` Guenter Roeck
2019-07-31 17:42 ` [PATCH 2/5] watchdog: ziirave_wdt: Be verbose about errors in probe() Andrey Smirnov
2019-07-31 21:42 ` Guenter Roeck
2019-07-31 17:42 ` [PATCH 3/5] watchdog: ziirave_wdt: Be more verbose during firmware update Andrey Smirnov
2019-07-31 21:43 ` Guenter Roeck
2019-07-31 17:42 ` [PATCH 4/5] watchdog: ziirave_wdt: Don't bail out on unexpected timeout value Andrey Smirnov
2019-07-31 18:09 ` Guenter Roeck
2019-08-10 21:17 ` Andrey Smirnov
2019-08-02 20:49 ` Guenter Roeck
2019-07-31 17:42 ` [PATCH 5/5] watchdog: ziirave_wdt: Log bootloader/firmware info during probe Andrey Smirnov
2019-07-31 21:44 ` Guenter Roeck
2019-07-31 18:11 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731181127.GB3885@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rick@anteaterllc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®