From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E44BC433FF for ; Wed, 31 Jul 2019 18:44:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35A29206A3 for ; Wed, 31 Jul 2019 18:44:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="MOyunKS4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730450AbfGaSoH (ORCPT ); Wed, 31 Jul 2019 14:44:07 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:42806 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730428AbfGaSoG (ORCPT ); Wed, 31 Jul 2019 14:44:06 -0400 Received: by mail-lj1-f194.google.com with SMTP id t28so66648738lje.9 for ; Wed, 31 Jul 2019 11:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=S8iymda7xPMQ4926S35iyef8N5nHE8NRBoOVEkW+KiU=; b=MOyunKS4ipxqo9LGPAcFwtqEOm8UGWkGuO7rQLbHcexMrHl3rDvDcdiO4C/Jo5RKI9 J4nc/lBbKWNLaF+MFCp8pJkWbpFpwXpaEDPUs6xCyXwZXrK3wQWniYdrY/NSf/UAIc1f WJSkyj+AFRo5ypChNb3XX+Z8/xrdfdVsppMWYKlwrTj4xdMOfLTMNvsD2d8OGKiS27ny jzhap1hRgLGYCamoJYJO9sJOtpJUOFij5jc9V5FtuEmYOwwfVdBmEVjZXIJm94pWEJsq 4xrheUp7DpybEuiXIh+NOJuyQ5KOK4NlU2zTmGmT3n6FzDJTiDO2LlI7kUsxMYERq126 mb5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=S8iymda7xPMQ4926S35iyef8N5nHE8NRBoOVEkW+KiU=; b=AnEqvfpfU1T7CzZTU5gv4eRN0mHsNDZtq1GZG0b0qi+BHGieu1rl+sD1sjPnNgiWoz lnu1QoCAFFACe1snnSqQNtKR2PSp4CXtMLnnueB0GLfTv5SSEN/qh0QNMuuEd5ISrajl kRTkzpQsRWDKbam0//PxV98hXuHr0DCFgYIFv08IcjqWvATBhUAP7eYXnjNGH5cr7+Xt MZ/f87ZMQ6UodSMRL/Lp4Wpd7ukxL86q3p3N0jD9JQE1lfUXaqWNezg7xmSWOZOQim9t 5Qb80Te3sOpN0MLXzJ/aPCCdS4B/gE31L2ASUtTmMpKtebE6GPT4Wj2RCZSfinO7oKp/ E2gg== X-Gm-Message-State: APjAAAUvHIqcB5e186JPL2phjJ+DceMf59cGvhN0H5HRcXjIOGT5MP8t W3T98yEEHhKTSFI3/Daa7j7s1Chi X-Google-Smtp-Source: APXvYqzk/7IbaRdwdAyiPhPaBK+fYqXkLLaHXkk14KwsgUDgjDgxSu4c1Upcw5nTh1Zua41AOjxpdg== X-Received: by 2002:a2e:994:: with SMTP id 142mr64164643ljj.130.1564598643913; Wed, 31 Jul 2019 11:44:03 -0700 (PDT) Received: from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32]) by smtp.gmail.com with ESMTPSA id f1sm14065815ljf.53.2019.07.31.11.44.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 11:44:03 -0700 (PDT) Date: Wed, 31 Jul 2019 20:44:02 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Marek Vasut , linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thermal: rcar_gen3_thermal: Use devm_add_action_or_reset() helper Message-ID: <20190731184402.GL3186@bigcity.dyn.berto.se> References: <20190731125053.14750-1-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190731125053.14750-1-geert+renesas@glider.be> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thanks for your work. On 2019-07-31 14:50:53 +0200, Geert Uytterhoeven wrote: > Use the devm_add_action_or_reset() helper instead of open-coding the > same operations. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > drivers/thermal/rcar_gen3_thermal.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c > index a56463308694e937..2db7e7f8baf939fd 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -443,11 +443,10 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) > if (ret) > goto error_unregister; > > - ret = devm_add_action(dev, rcar_gen3_hwmon_action, zone); > - if (ret) { > - rcar_gen3_hwmon_action(zone); > + ret = devm_add_action_or_reset(dev, rcar_gen3_hwmon_action, > + zone); > + if (ret) > goto error_unregister; > - } > > ret = of_thermal_get_ntrips(tsc->zone); > if (ret < 0) > -- > 2.17.1 > -- Regards, Niklas Söderlund