From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D69C433FF for ; Thu, 1 Aug 2019 07:46:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 245672087E for ; Thu, 1 Aug 2019 07:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731009AbfHAHqV (ORCPT ); Thu, 1 Aug 2019 03:46:21 -0400 Received: from verein.lst.de ([213.95.11.211]:41145 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728582AbfHAHqU (ORCPT ); Thu, 1 Aug 2019 03:46:20 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2CC4D227A81; Thu, 1 Aug 2019 09:46:15 +0200 (CEST) Date: Thu, 1 Aug 2019 09:46:14 +0200 From: Christoph Hellwig To: Bharata B Rao Cc: Christoph Hellwig , =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , Ralph Campbell , Andrew Morton , linux-mm@kvack.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] nouveau: simplify nouveau_dmem_migrate_to_ram Message-ID: <20190801074614.GC16178@lst.de> References: <20190729142843.22320-1-hch@lst.de> <20190729142843.22320-6-hch@lst.de> <20190731095735.GB18807@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731095735.GB18807@in.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 03:27:35PM +0530, Bharata B Rao wrote: > > - kfree(fault->dma); > > + return VM_FAULT_SIGBUS; > Looks like nouveau_dmem_fault_copy_one() is now returning VM_FAULT_SIGBUS > for success case. Is this expected? No, fixed.