mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Chuhong Yuan <hslester96@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/12] printk: Replace strncmp with str_has_prefix
Date: Thu, 1 Aug 2019 12:40:37 -0400	[thread overview]
Message-ID: <20190801124037.11dcac71@gandalf.local.home> (raw)
In-Reply-To: <917395fc42633b66abe3f713a9eef8edfdf7ee44.camel@perches.com>

On Thu, 01 Aug 2019 09:19:04 -0700
Joe Perches <joe@perches.com> wrote:

> > I find that checkpatch.pl forbids assignment in if condition.
> > So this seems to be infeasible...  
> 
> checkpatch is a stupid script and doesn't forbid
> anything.  It's just a suggestion guide.
> 
> Ignore checkpatch when you know better.

And this is coming from the checkpatch.pl maintainer ;-)

-- Steve

  reply	other threads:[~2019-08-01 16:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 15:15 Chuhong Yuan
2019-07-30  0:16 ` Joe Perches
2019-08-01 15:23   ` Chuhong Yuan
2019-08-01 16:19     ` Joe Perches
2019-08-01 16:40       ` Steven Rostedt [this message]
2019-08-01 17:51     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190801124037.11dcac71@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=hslester96@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®