From: Kees Cook <keescook@chromium.org>
To: Robin Lindner <robin.lindner1@t-online.de>
Cc: re.emese@gmail.com, kernel-hardening@lists.openwall.com,
Alexander Popov <alex.popov@linux.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation patch (gcc-plugins kernel)
Date: Thu, 1 Aug 2019 13:14:43 -0700 [thread overview]
Message-ID: <201908011311.A06FB03C6C@keescook> (raw)
In-Reply-To: <ebb6d995-a356-bc01-074b-6154a283e299@t-online.de>
On Thu, Aug 01, 2019 at 09:30:58AM +0200, Robin Lindner wrote:
> Cleaned documentation comment up. I removed the "TODO" because it was very old.
Hi, please send these patches "normally" (cc maintainers, include lkml,
inline not attachments, etc):
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> ---
> scripts/gcc-plugins/stackleak_plugin.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/scripts/gcc-plugins/stackleak_plugin.c b/scripts/gcc-plugins/stackleak_plugin.c
> index dbd37460c573e..d8ba12c3bb238 100644
> --- a/scripts/gcc-plugins/stackleak_plugin.c
> +++ b/scripts/gcc-plugins/stackleak_plugin.c
> @@ -144,8 +144,6 @@ static unsigned int stackleak_instrument_execute(void)
> *
> * Case in point: native_save_fl on amd64 when optimized for size
> * clobbers rdx if it were instrumented here.
> - *
> - * TODO: any more special cases?
> */
> if (is_leaf &&
> !TREE_PUBLIC(current_function_decl) &&
As to the content of the patch, let's also CC Alexander...
Are there no more special cases?
--
Kees Cook
next parent reply other threads:[~2019-08-01 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ebb6d995-a356-bc01-074b-6154a283e299@t-online.de>
2019-08-01 20:14 ` Kees Cook [this message]
2019-08-14 11:29 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908011311.A06FB03C6C@keescook \
--to=keescook@chromium.org \
--cc=alex.popov@linux.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=re.emese@gmail.com \
--cc=robin.lindner1@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®