From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60711C433FF for ; Thu, 1 Aug 2019 14:08:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41EC2216C8 for ; Thu, 1 Aug 2019 14:08:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731816AbfHAOIZ (ORCPT ); Thu, 1 Aug 2019 10:08:25 -0400 Received: from verein.lst.de ([213.95.11.211]:43788 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731468AbfHAOIY (ORCPT ); Thu, 1 Aug 2019 10:08:24 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 7FDE168AFE; Thu, 1 Aug 2019 16:08:20 +0200 (CEST) Date: Thu, 1 Aug 2019 16:08:20 +0200 From: Christoph Hellwig To: Nicolas Saenz Julienne Cc: catalin.marinas@arm.com, hch@lst.de, wahrenst@gmx.net, marc.zyngier@arm.com, Robin Murphy , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, phill@raspberryi.org, f.fainelli@gmail.com, will@kernel.org, robh+dt@kernel.org, eric@anholt.net, mbrugger@suse.com, akpm@linux-foundation.org, frowand.list@gmail.com, m.szyprowski@samsung.com, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] mm: comment arm64's usage of 'enum zone_type' Message-ID: <20190801140820.GC23435@lst.de> References: <20190731154752.16557-1-nsaenzjulienne@suse.de> <20190731154752.16557-9-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731154752.16557-9-nsaenzjulienne@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 05:47:51PM +0200, Nicolas Saenz Julienne wrote: > + * Architecture Limit > + * ---------------------------------- > + * parisc, ia64, sparc, arm64 <4G > + * s390, powerpc <2G > + * arm Various > + * alpha Unlimited or 0-16MB. > * > * i386, x86_64 and multiple other arches > - * <16M. > + * <16M. powerpc is also Various now, arm64 isn't really < 4G, ia64 only uses ZONE_DMA32 these days, and parisc doesn't seem to use neither ZONE_DMA nor ZONE_DMA32. Based on that I'm not sure the list really makes much sense. > */ > ZONE_DMA, > #endif > #ifdef CONFIG_ZONE_DMA32 > /* > - * x86_64 needs two ZONE_DMAs because it supports devices that are > - * only able to do DMA to the lower 16M but also 32 bit devices that > - * can only do DMA areas below 4G. > + * x86_64 and arm64 need two ZONE_DMAs because they support devices > + * that are only able to DMA a fraction of the 32 bit addressable > + * memory area, but also devices that are limited to that whole 32 bit > + * area. > */ > ZONE_DMA32, Maybe just say various architectures instead of mentioning specific ones? Something like "Some 64-bit platforms need.."