From: Matthias Kaehlcke <mka@chromium.org>
To: "David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: [PATCH v4 2/4] net: phy: Add function to retrieve LED configuration from the DT
Date: Thu, 1 Aug 2019 12:07:57 -0700 [thread overview]
Message-ID: <20190801190759.28201-3-mka@chromium.org> (raw)
In-Reply-To: <20190801190759.28201-1-mka@chromium.org>
Add a phylib function for retrieving PHY LED configuration that
is specified in the device tree using the generic binding. LEDs
can be configured to be 'on' for a certain link speed or to blink
when there is TX/RX activity.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v4:
- patch added to the series
---
drivers/net/phy/phy_device.c | 50 ++++++++++++++++++++++++++++++++++++
include/linux/phy.h | 15 +++++++++++
2 files changed, 65 insertions(+)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 6b5cb87f3866..b4b48de45712 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -2188,6 +2188,56 @@ static bool phy_drv_supports_irq(struct phy_driver *phydrv)
return phydrv->config_intr && phydrv->ack_interrupt;
}
+int of_get_phy_led_cfg(struct phy_device *phydev, int led,
+ struct phy_led_config *cfg)
+{
+ struct device_node *np, *child;
+ const char *trigger;
+ int ret;
+
+ if (!IS_ENABLED(CONFIG_OF_MDIO))
+ return -ENOENT;
+
+ np = of_find_node_by_name(phydev->mdio.dev.of_node, "leds");
+ if (!np)
+ return -ENOENT;
+
+ for_each_child_of_node(np, child) {
+ u32 val;
+
+ if (!of_property_read_u32(child, "reg", &val)) {
+ if (val == (u32)led)
+ break;
+ }
+ }
+
+ if (!child)
+ return -ENOENT;
+
+ ret = of_property_read_string(child, "linux,default-trigger",
+ &trigger);
+ if (ret)
+ return ret;
+
+ if (!strcmp(trigger, "phy_link_10m_active")) {
+ cfg->trigger = PHY_LED_LINK_10M;
+ } else if (!strcmp(trigger, "phy_link_100m_active")) {
+ cfg->trigger = PHY_LED_LINK_100M;
+ } else if (!strcmp(trigger, "phy_link_1g_active")) {
+ cfg->trigger = PHY_LED_LINK_1G;
+ } else if (!strcmp(trigger, "phy_link_10g_active")) {
+ cfg->trigger = PHY_LED_LINK_10G;
+ } else if (!strcmp(trigger, "phy_activity")) {
+ cfg->trigger = PHY_LED_ACTIVITY;
+ } else {
+ phydev_warn(phydev, "trigger '%s' for LED%d is invalid\n",
+ trigger, led);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
/**
* phy_probe - probe and init a PHY device
* @dev: device to probe and init
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 462b90b73f93..b4693415be31 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1176,6 +1176,21 @@ int phy_ethtool_set_link_ksettings(struct net_device *ndev,
const struct ethtool_link_ksettings *cmd);
int phy_ethtool_nway_reset(struct net_device *ndev);
+enum phy_led_trigger {
+ PHY_LED_LINK_10M,
+ PHY_LED_LINK_100M,
+ PHY_LED_LINK_1G,
+ PHY_LED_LINK_10G,
+ PHY_LED_ACTIVITY,
+};
+
+struct phy_led_config {
+ enum phy_led_trigger trigger;
+};
+
+int of_get_phy_led_cfg(struct phy_device *phydev, int led,
+ struct phy_led_config *cfg);
+
#if IS_ENABLED(CONFIG_PHYLIB)
int __init mdio_bus_init(void);
void mdio_bus_exit(void);
--
2.22.0.770.g0f2c4a37fd-goog
next prev parent reply other threads:[~2019-08-01 19:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 19:07 [PATCH v4 0/4] net: phy: realtek: Enable configuration of RTL8211E LEDs Matthias Kaehlcke
2019-08-01 19:07 ` [PATCH v4 1/4] dt-bindings: net: phy: Add subnode for LED configuration Matthias Kaehlcke
2019-08-02 16:57 ` Andrew Lunn
2019-08-02 18:27 ` Matthias Kaehlcke
2019-08-01 19:07 ` Matthias Kaehlcke [this message]
2019-08-02 16:38 ` [PATCH v4 2/4] net: phy: Add function to retrieve LED configuration from the DT Andrew Lunn
2019-08-02 17:59 ` Matthias Kaehlcke
2019-08-01 19:07 ` [PATCH v4 3/4] net: phy: realtek: Add helpers for accessing RTL8211E extension pages Matthias Kaehlcke
2019-08-04 8:33 ` Heiner Kallweit
2019-08-06 21:58 ` Matthias Kaehlcke
2019-08-01 19:07 ` [PATCH v4 4/4] net: phy: realtek: configure RTL8211E LEDs Matthias Kaehlcke
2019-08-01 21:04 ` David Miller
2019-08-02 18:18 ` Andrew Lunn
2019-08-02 19:40 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801190759.28201-3-mka@chromium.org \
--to=mka@chromium.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®