From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC656C433FF for ; Fri, 2 Aug 2019 13:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BE9E21851 for ; Fri, 2 Aug 2019 13:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564752334; bh=qP8vCx5KYpcvlcNbOBJpV72B0xJIr42ZOgtEcRP7yIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WnNRwHauUg3LP2R1EnuThHpAqfNfF94VZf3ieVul39rLM3Cjo/i4cQ+XvdbjiV23G 7KfSHYL97vuUT/q8/8mdeKlQE9bNo1p96QItQLXQubTAhNOvbDEm+bJ3ObwLsT8MiB qKm1u8ivgqCHmAw5jGH1pTslIqdcAWVO3tfnZhPI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390712AbfHBNZd (ORCPT ); Fri, 2 Aug 2019 09:25:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:36216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391319AbfHBNZa (ORCPT ); Fri, 2 Aug 2019 09:25:30 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FAA021841; Fri, 2 Aug 2019 13:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564752329; bh=qP8vCx5KYpcvlcNbOBJpV72B0xJIr42ZOgtEcRP7yIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KlpuOquiL9ENyRGbdvbpgO/KJ3Z+muHERIpTJZHqX2K64iVp1p8odgU2BvRALKa8Z Ddbyb2l33dmd7+/+OmIJ71t/8g8dneKBKBJnAP/eKgBRkVh8YEpu3FljbWsoUQ1Rum PrP3FEopiQ+nHTa9YSggX+KtmqV/KSyzD2c5AbKQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wenwen Wang , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 27/30] test_firmware: fix a memory leak bug Date: Fri, 2 Aug 2019 09:24:19 -0400 Message-Id: <20190802132422.13963-27-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190802132422.13963-1-sashal@kernel.org> References: <20190802132422.13963-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang [ Upstream commit d4fddac5a51c378c5d3e68658816c37132611e1f ] In test_firmware_init(), the buffer pointed to by the global pointer 'test_fw_config' is allocated through kzalloc(). Then, the buffer is initialized in __test_firmware_config_init(). In the case that the initialization fails, the following execution in test_firmware_init() needs to be terminated with an error code returned to indicate this failure. However, the allocated buffer is not freed on this execution path, leading to a memory leak bug. To fix the above issue, free the allocated buffer before returning from test_firmware_init(). Signed-off-by: Wenwen Wang Link: https://lore.kernel.org/r/1563084696-6865-1-git-send-email-wang6495@umn.edu Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- lib/test_firmware.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/test_firmware.c b/lib/test_firmware.c index f978aebe60c5b..2e5e18bbfd28e 100644 --- a/lib/test_firmware.c +++ b/lib/test_firmware.c @@ -895,8 +895,11 @@ static int __init test_firmware_init(void) return -ENOMEM; rc = __test_firmware_config_init(); - if (rc) + if (rc) { + kfree(test_fw_config); + pr_err("could not init firmware test config: %d\n", rc); return rc; + } rc = misc_register(&test_fw_misc_device); if (rc) { -- 2.20.1