From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49F9C433FF for ; Fri, 2 Aug 2019 14:59:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB3682087C for ; Fri, 2 Aug 2019 14:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395102AbfHBO7w (ORCPT ); Fri, 2 Aug 2019 10:59:52 -0400 Received: from foss.arm.com ([217.140.110.172]:53618 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbfHBO7w (ORCPT ); Fri, 2 Aug 2019 10:59:52 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8DF21596; Fri, 2 Aug 2019 07:59:51 -0700 (PDT) Received: from e107985-lin.arm.com (e107985-lin.cambridge.arm.com [10.1.194.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 906533F575; Fri, 2 Aug 2019 07:59:50 -0700 (PDT) From: Dietmar Eggemann To: Peter Zijlstra , Ingo Molnar , Juri Lelli Cc: Luca Abeni , Daniel Bristot de Oliveira , Valentin Schneider , Qais Yousef , linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] sched/deadline: Fix double accounting in push_dl_task() & some cleanups Date: Fri, 2 Aug 2019 15:59:42 +0100 Message-Id: <20190802145945.18702-1-dietmar.eggemann@arm.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While running a simple DL workload (1 DL (12000/100000/100000) task per CPU) on Arm64 & x86 systems I noticed that some of the SCHED_WARN_ON() in the rq/running bandwidth (bw) functions trigger. Patch 1/3 contains a proposal to fix this. Patch 2-3/3 contain smaller cleanups I discovered while debugging the actual issue. Changes v1->v2: - Remove rq/running bw accounting in pull_dl_task() as well [1/3] - Remove v1's "sched/deadline: Remove unused int flags from __dequeue_task_dl()" - Change return to BUG_ON() in dequeue in !on_dl_rq case [3/3] - Remove v1's "sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting" Dietmar Eggemann (3): sched/deadline: Fix double accounting of rq/running bw in push & pull sched/deadline: Use __sub_running_bw() throughout dl_change_utilization() sched/deadline: Cleanup on_dl_rq() handling kernel/sched/deadline.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) -- 2.17.1