From: Peter Zijlstra <peterz@infradead.org>
To: Cheng Jian <cj.chengjian@huawei.com>
Cc: mingo@redhat.com, xiexiuqi@huawei.com, huawei.libin@huawei.com,
bobo.shaobowang@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/core: decrease rq->nr_uninterruptible before set_task_cpu
Date: Tue, 6 Aug 2019 16:19:22 +0200 [thread overview]
Message-ID: <20190806141922.GT2332@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1565100770-110193-1-git-send-email-cj.chengjian@huawei.com>
On Tue, Aug 06, 2019 at 10:12:50PM +0800, Cheng Jian wrote:
> Migration may occur when wake up a process, so we must update
> the rq->nr_uninterruptible before set_task_cpu, otherwise we
> will decrease the nr_interuptible of the incorrect rq. Over
> time, it cause some rq accounting according to be too large,
> but others are negative.
>
> Also change the type of rq->nr_uninterruptible to atomic_t.
NAK. Also there is no actual problem description there.
prev parent reply other threads:[~2019-08-06 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 14:12 Cheng Jian
2019-08-06 14:19 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806141922.GT2332@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bobo.shaobowang@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®