From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633E7C433FF for ; Tue, 6 Aug 2019 20:04:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 230BA214C6 for ; Tue, 6 Aug 2019 20:04:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="dcd3JYDJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbfHFUD7 (ORCPT ); Tue, 6 Aug 2019 16:03:59 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:35848 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbfHFUD6 (ORCPT ); Tue, 6 Aug 2019 16:03:58 -0400 Received: by mail-qt1-f194.google.com with SMTP id z4so85963998qtc.3 for ; Tue, 06 Aug 2019 13:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=X4WStm4sd99gxcsiHRK905oUotgl76w2o1W1C4yVJ6I=; b=dcd3JYDJk152NlFfhO/9qO7tld2EmCF8YFkFxS8Gs6O3Eoi2v5a/p+kLVV72KaaDZH 4AOPO6UQwsqqSpKlkkmk62Hxppen7/IFJKSpOLIvaEcL3N5LOWdJcJ3uwdOeXMO99Q9Q Y+QyzsRM0n6nW3nAnKygZxiG5A+b6hJR/51n9u0k+imi9/6Ip/PFhv8jDVoF1QLCfhOE mc8U5KqjaSeDQJIru7Rkv0aQxcqZ/bBs3+8ohxG0EleOYIJ0yGSZ17/3ZQ9kmYzGdGc9 lnGhK+bfHIxMwOWyuDrIFwNQZiRvrAKnQOXdx2VYo9gZpFBLdNdodmHnLp7wXWjv5EFF EsSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=X4WStm4sd99gxcsiHRK905oUotgl76w2o1W1C4yVJ6I=; b=pK8813+Z8oe0MYZ/5W6mVNMsOeV0lmTv+qlm/6tlhu0DKsJ+ChaH9428GkRWTruWu8 f6xm6raihJiBIfNC4osPzr5RBjyeakBEy+dek1g2kkC3T3c6cWnOPGlLf3hySti2ULFw +YEG++xYS+P3v56B7rHIhvuSTGsZ94ENQGlhdVOqDmeN9eMWT7QUB9VtgXTE1gwKG8ST 49VF9YyCC1snkQQsxig4nvoKWxm5a9qtJRsBKZVAWN66a5emWxieAOcQ+0n31sxWhFp5 ZH8jk+dGfzlREH1o3F76z3ImqIM5piCqC0V+gz/tsujiq4qKCJm72vrTXaDml6899aSR GvtQ== X-Gm-Message-State: APjAAAWOQ7b4+lRBfUTdLkq2OkAZfQXkbGeFXI9XEVCL0YPeernsFebq ImsPCdYDFsL/f9ovQaDTIkh+bA== X-Google-Smtp-Source: APXvYqx6UY5l/vYT32k/wTnl8SPfwuXYE5Fx1fiKKYFrCmOXi/6TIYwyn3yhKlGhO9HMcVXQYwiuNw== X-Received: by 2002:ac8:3118:: with SMTP id g24mr4769493qtb.390.1565121837686; Tue, 06 Aug 2019 13:03:57 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id g10sm35341761qki.37.2019.08.06.13.03.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Aug 2019 13:03:57 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hv5ga-0003dB-O6; Tue, 06 Aug 2019 17:03:56 -0300 Date: Tue, 6 Aug 2019 17:03:56 -0300 From: Jason Gunthorpe To: Alex Deucher Cc: "Kuehling, Felix" , Christoph Hellwig , "Deucher, Alexander" , "Koenig, Christian" , Ralph Campbell , "amd-gfx@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ben Skeggs Subject: Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR Message-ID: <20190806200356.GU11627@ziepe.ca> References: <20190806160554.14046-1-hch@lst.de> <20190806160554.14046-16-hch@lst.de> <20190806174437.GK11627@ziepe.ca> <587b1c3c-83c4-7de9-242f-6516528049f4@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 06, 2019 at 02:58:58PM -0400, Alex Deucher wrote: > On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > > >> The option is just used to select HMM mirror support and has a very > > >> confusing help text. Just pull in the HMM mirror code by default > > >> instead. > > >> > > >> Signed-off-by: Christoph Hellwig > > >> drivers/gpu/drm/Kconfig | 2 ++ > > >> drivers/gpu/drm/amd/amdgpu/Kconfig | 10 ---------- > > >> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ------ > > >> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 12 ------------ > > >> 4 files changed, 2 insertions(+), 28 deletions(-) > > > Felix, was this an effort to avoid the arch restriction on hmm or > > > something? Also can't see why this was like this. > > > > This option predates KFD's support of userptrs, which in turn predates > > HMM. Radeon has the same kind of option, though it doesn't affect HMM in > > that case. > > > > Alex, Christian, can you think of a good reason to maintain userptr > > support as an option in amdgpu? I suspect it was originally meant as a > > way to allow kernels with amdgpu without MMU notifiers. Now it would > > allow a kernel with amdgpu without HMM or MMU notifiers. I don't know if > > this is a useful thing to have. > > Right. There were people that didn't have MMU notifiers that wanted > support for the GPU. ?? Is that even a real thing? mmu_notifier does not have much kconfig dependency. Jason