From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B66D1C433FF for ; Wed, 7 Aug 2019 02:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A02E214C6 for ; Wed, 7 Aug 2019 02:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Kl5CEiJl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728863AbfHGCGE (ORCPT ); Tue, 6 Aug 2019 22:06:04 -0400 Received: from mail-pl1-f201.google.com ([209.85.214.201]:34123 "EHLO mail-pl1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728547AbfHGCGE (ORCPT ); Tue, 6 Aug 2019 22:06:04 -0400 Received: by mail-pl1-f201.google.com with SMTP id 71so49474016pld.1 for ; Tue, 06 Aug 2019 19:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=bdbKWZyjXxZ8gdygSGa9lktCzX8kxlzXL6a6uqaX3bg=; b=Kl5CEiJl/MaPfmQJRxpS2c1fPM5g/w735FsApDzzZzR56wnn0csvwjboJv9Jbjz6HU vULA/nOTL4J4BJHrQftcA5iZOBear0d0K+loneShngKG8oeNAQuDxzwMKm1WisYQt+bT TfB1p2/qViJhOuUXXbCYyBckBgngIgMdLbnJBHq6gDAG3/oAHyA7PT0r5upuG9zuUFT2 Uh2jMJhH1OR0iTVbYZOqnGrUHeA4q+AEZq8T+tELAUzKJhpyHiw1EAs5RE6tv+80w1d5 mhDvo5Gw65tAIC6BvkdzOdnOmeVyQTjv5vOEt/cktNZ2pwNHbN/kH1xN5qdmBgHTU780 4bHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=bdbKWZyjXxZ8gdygSGa9lktCzX8kxlzXL6a6uqaX3bg=; b=abn9ikNQo+dM5bQN9KGkrAL2vB6TXyu0dGBY3RnuVOKRle5kjFHvPbgnL1aGb6A+qE EnDqkW2Q5Y7+jtvdiwdRl7mx6Tm4SZTiD/QpwSK2RWDTvynhUnTCS2UeQM+6yRPh0v77 Z+Wj9JpGomZwMB/ULMfUv4derv0yCEc6wUWHIA+9nzFHi7gWUBh7e/iF/KurjnIDSpHs dkRKtn0af127yk8BlD2BntIVKO2lFCldAP6+Uq7lZxILopr+wnoWmQvEWFrRgjcuMbX6 hG39T8uEvNF9LiWqZC3TdxuU22OJLCjuSp4adXdoYx1Eb40MvJOXnz6goNTpgcXGoThc Q+eg== X-Gm-Message-State: APjAAAWl3ouyrjAJffedTTo6bsDiwE6DjPhpvLe1/COoroOq8mBVGK09 oZrsGalIwXgDNBysbY2zWEus5oyQ2h6apRg= X-Google-Smtp-Source: APXvYqxcuEsLSdZXABfbaGLaPekdX0qCbxv3NGBtyC6zvs/T/8g2c6CDTAef9YrNBjb4Nx8tt8f2dLmZFckRn/4= X-Received: by 2002:a63:f07:: with SMTP id e7mr5914306pgl.238.1565143563303; Tue, 06 Aug 2019 19:06:03 -0700 (PDT) Date: Tue, 6 Aug 2019 19:05:58 -0700 Message-Id: <20190807020559.74458-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog Subject: [PATCH] of/platform: Fix device_links_supplier_sync_state_resume() warning From: Saravana Kannan To: Greg Kroah-Hartman , Rob Herring , Frank Rowand Cc: Saravana Kannan , Qian Cai , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In platforms/devices which have CONFIG_OF turned on but don't have a populated DT, the calls to device_links_supplier_sync_state_pause() and device_links_supplier_sync_state_resume() can get mismatched. This will cause a warning during boot. Fix the warning by making sure the calls are matched even in that case. Reported-by: Qian Cai Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index a2a4e4b79d43..e5f7e40df439 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -723,7 +723,8 @@ arch_initcall_sync(of_platform_default_populate_init); static int __init of_platform_sync_state_init(void) { - device_links_supplier_sync_state_resume(); + if (of_have_populated_dt()) + device_links_supplier_sync_state_resume(); return 0; } late_initcall_sync(of_platform_sync_state_init); -- 2.23.0.rc1.153.gdeed80330f-goog