From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21B5C32751 for ; Wed, 7 Aug 2019 11:46:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9CDD21BF6 for ; Wed, 7 Aug 2019 11:46:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="U08Ufgqo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729858AbfHGLqg (ORCPT ); Wed, 7 Aug 2019 07:46:36 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:40016 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728235AbfHGLqg (ORCPT ); Wed, 7 Aug 2019 07:46:36 -0400 Received: by mail-qt1-f195.google.com with SMTP id a15so87897796qtn.7 for ; Wed, 07 Aug 2019 04:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9tcMRoCrJOgypBCjgMnEianhaeJlCGMLrqGgBoLjIDU=; b=U08UfgqoDECwAr2QVZQUgZK40EFADE7BB9s9xvrIZg9BnRq7d95CB83a2OkP1WEJcj FJHxKesZGFWoqIF2Qvx18DQ0QvKbjikgKunvpDQdaSIZ0xtKT4N7Aaxnh+uo7IY4chsI EfR9d/3Agjm/w1qM55xjv8+yMuR6GmpagkJuTiZ1huMV62pE12VP4QStafaX4bqEbCF5 nKofSYhlitBlOo14ZSx+w2EM6o/0BqEsL16SZ9EMLbCiY4rRVsTQde2O8lzNMJEb+Cq/ Vx2rLEgsoxjAWUNTBox+Ov8foZ2VXl/0VY0B4PKb+rOpSVgQBrfb34kDq3jWYLCsqCZd XwCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9tcMRoCrJOgypBCjgMnEianhaeJlCGMLrqGgBoLjIDU=; b=kPyoeu+g1kiupkhj1slD0RNk0YPghZhdzmSonvKysUwTgZIYrn3vBMUmxag8OU/3gK OMWeHT1SWZPz48YIHfU2jd7PPUnrRRELg/uuKbnr6OBNLpmUMswDcWZRRjdfn2I3bULg Q5atbwouUOYovj0W6m2Ze+AflnUN4iPR5ipFVxHyye4hVY4Pk9jIgmw8qQtNDCpPJIUm LS4Ylr/SWE/gbGPa/f2TDPb+Vcdpa6daONavZ+JTgoXtYtyiHMA0Why5GV35N+ycCPRV fK/waD3xKjjr2RD2oLaXGy+Qxc8WDlVpvUB5ZTq9Xwfwny/OSZ69Q7Z3GjIqcIaKwzKk 06iA== X-Gm-Message-State: APjAAAVtD3Jf0IljDGCD2zvfu+asJH2rGiJZO91PEuQ+tvaNOdcI8t/G Sz/3N+ByzD7T700UchzvAW4zxg== X-Google-Smtp-Source: APXvYqwgiLU0pSR3tJqkM4Nqx6SM116MNW2dWYs7m0gkaOSNuRmQOq6FVBT9RTAhBGfUW5xdKQEVPQ== X-Received: by 2002:aed:24d9:: with SMTP id u25mr7755713qtc.111.1565178394864; Wed, 07 Aug 2019 04:46:34 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id a135sm40043046qkg.72.2019.08.07.04.46.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Aug 2019 04:46:34 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hvKOn-0000fJ-NF; Wed, 07 Aug 2019 08:46:33 -0300 Date: Wed, 7 Aug 2019 08:46:33 -0300 From: Jason Gunthorpe To: "Koenig, Christian" Cc: Alex Deucher , "Kuehling, Felix" , Christoph Hellwig , "Deucher, Alexander" , Ralph Campbell , "amd-gfx@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ben Skeggs Subject: Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR Message-ID: <20190807114633.GA1557@ziepe.ca> References: <20190806160554.14046-1-hch@lst.de> <20190806160554.14046-16-hch@lst.de> <20190806174437.GK11627@ziepe.ca> <587b1c3c-83c4-7de9-242f-6516528049f4@amd.com> <20190806200356.GU11627@ziepe.ca> <4a040a3f-8981-3e94-2436-8295a0caa534@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a040a3f-8981-3e94-2436-8295a0caa534@amd.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 06:57:24AM +0000, Koenig, Christian wrote: > Am 06.08.19 um 22:03 schrieb Jason Gunthorpe: > > On Tue, Aug 06, 2019 at 02:58:58PM -0400, Alex Deucher wrote: > >> On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > >>> On 2019-08-06 13:44, Jason Gunthorpe wrote: > >>>> On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > >>>>> The option is just used to select HMM mirror support and has a very > >>>>> confusing help text. Just pull in the HMM mirror code by default > >>>>> instead. > >>>>> > >>>>> Signed-off-by: Christoph Hellwig > >>>>> drivers/gpu/drm/Kconfig | 2 ++ > >>>>> drivers/gpu/drm/amd/amdgpu/Kconfig | 10 ---------- > >>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 ------ > >>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 12 ------------ > >>>>> 4 files changed, 2 insertions(+), 28 deletions(-) > >>>> Felix, was this an effort to avoid the arch restriction on hmm or > >>>> something? Also can't see why this was like this. > >>> This option predates KFD's support of userptrs, which in turn predates > >>> HMM. Radeon has the same kind of option, though it doesn't affect HMM in > >>> that case. > >>> > >>> Alex, Christian, can you think of a good reason to maintain userptr > >>> support as an option in amdgpu? I suspect it was originally meant as a > >>> way to allow kernels with amdgpu without MMU notifiers. Now it would > >>> allow a kernel with amdgpu without HMM or MMU notifiers. I don't know if > >>> this is a useful thing to have. > >> Right. There were people that didn't have MMU notifiers that wanted > >> support for the GPU. > > ?? Is that even a real thing? mmu_notifier does not have much kconfig > > dependency. > > Yes, that used to be a very real thing. > > Initially a lot of users didn't wanted mmu notifiers to be enabled > because of the performance overhead they costs. Seems strange to hear these days, every distro ships with it on, it is needed for kvm. > Then we had the problem that HMM mirror wasn't available on a lot of > architectures. Some patches for hmm are ready now that will fix this Jason