From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FA1C31E40 for ; Wed, 7 Aug 2019 01:51:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E06E21743 for ; Wed, 7 Aug 2019 01:51:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="FAdBHtEi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728790AbfHGBvp (ORCPT ); Tue, 6 Aug 2019 21:51:45 -0400 Received: from ozlabs.org ([203.11.71.1]:34389 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727710AbfHGBvp (ORCPT ); Tue, 6 Aug 2019 21:51:45 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 463Dy34Y5hz9sDB; Wed, 7 Aug 2019 11:51:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1565142702; bh=VeIbhaZVUjebNvzkG6IBGnOOmwzkmjPxm/rSjwrHZoE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FAdBHtEiCRkCClZrOxjx+YjFKEl1GkEhZBHY4+noeXINNg9c4fSSuIWUHyFsbvT7P 2GSafOOi9fgWmJhVDT7GC/swkNz34D0kf4+MXvi1hWAmBVc9i8HVtDShBUNO95GKiq p6fiqGtam/JgnziFJwNtN2WluqW48ERgyuvj21sgfYdRToBmTwQGEDqOqEWDMv9MEe jZdqTkTHmps9kSeo4Jv5LgtnPhP5P6gmW/evpapYV4TdPBSmg3HNAWrnDSi+qmacM0 WCmpKDS5oWRNX/lpSR41iT7/bJgFgApDs/IlHyiDws6XHmmk+eHtM7R9czjotrwzJp IG2ZxsH8954UQ== Date: Wed, 7 Aug 2019 11:51:38 +1000 From: Stephen Rothwell To: Gao Xiang Cc: Gao Xiang , devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org, Theodore Ts'o , "Darrick J . Wong" , Greg Kroah-Hartman , Jan Kara , Amir Goldstein , Dave Chinner , David Sterba , LKML , Christoph Hellwig , Miao Xie , Alexander Viro , Pavel Machek , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Andrew Morton , Linus Torvalds Subject: Re: [PATCH RFC] erofs: move erofs out of staging Message-ID: <20190807115138.216fcb70@canb.auug.org.au> In-Reply-To: <20190806170252.GB29093@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20190806094925.228906-1-gaoxiang25@huawei.com> <20190807013423.02fd6990@canb.auug.org.au> <20190806170252.GB29093@hsiangkao-HP-ZHAN-66-Pro-G1> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/gC.BuFJhkfrfyrKHDgetbAs"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/gC.BuFJhkfrfyrKHDgetbAs Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Gao, On Wed, 7 Aug 2019 01:02:58 +0800 Gao Xiang wrote: > > On Wed, Aug 07, 2019 at 01:34:23AM +1000, Stephen Rothwell wrote: > >=20 > > One small suggestion: just remove the file names from the comments at > > the top of the files rather than change them to reflect that they have > > moved. We can usually tell the name of a file by its name :-) =20 >=20 > Thanks for your reply :) >=20 > For this part, EROFS initially followed what ext4, f2fs, even fsverity do, > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/f= s/ext4/namei.c > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/f= s/f2fs/namei.c > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/tree/f= s/verity/verify.c?h=3Dfsverity >=20 > I think I can remove these filenames as you suggested in the next version. > I thought these are some common practice and there is no obvious right or > wrong of this kind of stuffs. Fair enough. --=20 Cheers, Stephen Rothwell --Sig_/gC.BuFJhkfrfyrKHDgetbAs Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1KLqoACgkQAVBC80lX 0Gxjdwf+K7Z5+Ja83AA54PTZcXIHB9g+PdWvrL3aangZfmAt86GXDFF91vO1NlYp QNmMTIr9j0lMhNdCseZUWB8ejrFfWSbrq654EtAo+1ydYSZXBmjGXQ5FQtWMhfpZ e+4IRlkrOybVtYgU9nRfI2CIfCh8Z9Ol53Jh1M2bxDJw94XrZJug1N1S2j4+0Mta jaV8MWN/niTb4SsWls1Uha3DwvvpVHqc9645UMwJ5yFqzvsk7tJ/ViQWHQNvjGFH XdUqEMv40XEYGt3HrC8wzMPfubVVpdke556Ou5aQuTgYbsNOU5bTblzNvpIG9jpX xRDrkTjcnjGG6jRyqHN4XMzVrdPtwQ== =iqs3 -----END PGP SIGNATURE----- --Sig_/gC.BuFJhkfrfyrKHDgetbAs--