From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EABEAC433FF for ; Wed, 7 Aug 2019 12:44:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0A1621BF6 for ; Wed, 7 Aug 2019 12:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387875AbfHGMoI (ORCPT ); Wed, 7 Aug 2019 08:44:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:48656 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387777AbfHGMoH (ORCPT ); Wed, 7 Aug 2019 08:44:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B5E05AC64; Wed, 7 Aug 2019 12:44:05 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 617BDDA7D7; Wed, 7 Aug 2019 14:44:37 +0200 (CEST) Date: Wed, 7 Aug 2019 14:44:37 +0200 From: David Sterba To: Greg KH Cc: dsterba@suse.cz, Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Sterba , Filipe Manana , linux-btrfs@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.19 12/32] Btrfs: fix deadlock between fiemap and transaction commits Message-ID: <20190807124437.GT28208@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Greg KH , Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Sterba , Filipe Manana , linux-btrfs@vger.kernel.org References: <20190806213522.19859-1-sashal@kernel.org> <20190806213522.19859-12-sashal@kernel.org> <20190807094759.GQ28208@suse.cz> <20190807105126.GA14880@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807105126.GA14880@kroah.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 07, 2019 at 12:51:26PM +0200, Greg KH wrote: > On Wed, Aug 07, 2019 at 11:47:59AM +0200, David Sterba wrote: > > On Tue, Aug 06, 2019 at 05:35:00PM -0400, Sasha Levin wrote: > > > From: Filipe Manana > > > > > > [ Upstream commit a6d155d2e363f26290ffd50591169cb96c2a609e ] > > > > > > Fixes: 03628cdbc64db6 ("Btrfs: do not start a transaction during fiemap") > > > > The commit is a regression fix during the 5.2 cycle, how it could end up > > in a 4.19 stable candidate? > > > > $ git describe 03628cdbc64db6 > > v5.1-rc7-201-g03628cdbc64d > > > > $ git describe --contains 03628cdbc64db6 > > v5.2-rc1~163^2~26 > > > > And it does not belong to 5.2 either, git cherry-pick on top of 5.2 > > fails. > > > > I think such sanity check can be done automatically so the patches don't > > accidentally land in trees where don't belong. > > > Commit 03628cdbc64d ("Btrfs: do not start a transaction during fiemap") > was tagged for the stable trees, and ended up in the following releases: > 4.14.121 4.19.45 5.0.18 5.1.4 5.2 > so yes, it does need to go back to all of those locations if this patch > really does fix the issue there. You're right, I did not notice the CC tag when examining the patches.