From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org
Subject: [PATCH 3/3] sched/fair: Check for CFS tasks in active_load_balance_cpu_stop()
Date: Wed, 7 Aug 2019 18:40:26 +0100 [thread overview]
Message-ID: <20190807174026.31242-4-valentin.schneider@arm.com> (raw)
In-Reply-To: <20190807174026.31242-1-valentin.schneider@arm.com>
We should really only be looking for CFS tasks, since that's all
detach_one_task() can ever pull.
Replace the rq.nr_running check with a rq.cfs.h_nr_running one to do
just that.
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
kernel/sched/fair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 79bd6ead589c..099aad1930bb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9206,8 +9206,8 @@ static int active_load_balance_cpu_stop(void *data)
!busiest_rq->active_balance))
goto out_unlock;
- /* Is there any task to move? */
- if (busiest_rq->nr_running <= 1)
+ /* Is there any CFS task to move? */
+ if (busiest_rq->cfs.h_nr_running < 1)
goto out_unlock;
/*
--
2.22.0
prev parent reply other threads:[~2019-08-07 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 17:40 [PATCH 0/3] sched/fair: Active balancer RT/DL preemption fix Valentin Schneider
2019-08-07 17:40 ` [PATCH 1/3] sched/fair: Move active balance logic to its own function Valentin Schneider
2019-08-07 17:40 ` [PATCH 2/3] sched/fair: Prevent active LB from preempting higher sched classes Valentin Schneider
2019-08-08 9:24 ` Qais Yousef
2019-08-08 10:46 ` Valentin Schneider
2019-08-07 17:40 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807174026.31242-4-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®