From: Stefan Agner <stefan@agner.ch>
To: perex@perex.cz, tiwai@suse.com
Cc: lgirdwood@gmail.com, broonie@kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Stefan Agner <stefan.agner@toradex.com>
Subject: [PATCH] ASoC: soc-core: remove error due to probe deferral
Date: Thu, 8 Aug 2019 14:36:55 +0200 [thread overview]
Message-ID: <20190808123655.31520-1-stefan@agner.ch> (raw)
From: Stefan Agner <stefan.agner@toradex.com>
Deferred probes shouldn't cause error messages in the boot log. Avoid
printing with dev_err() in case EPROBE_DEFER is the return value.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
---
sound/soc/soc-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index fd6eaae6c0ed..98e1e80b5493 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1985,9 +1985,11 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card)
mutex_lock(&client_mutex);
for_each_card_prelinks(card, i, dai_link) {
ret = soc_init_dai_link(card, dai_link);
- if (ret) {
+ if (ret && ret != -EPROBE_DEFER) {
dev_err(card->dev, "ASoC: failed to init link %s: %d\n",
dai_link->name, ret);
+ }
+ if (ret) {
mutex_unlock(&client_mutex);
return ret;
}
--
2.22.0
next reply other threads:[~2019-08-08 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 12:36 Stefan Agner [this message]
2019-08-08 12:44 ` Mark Brown
2019-08-08 12:59 ` Stefan Agner
2019-08-08 13:00 ` Takashi Iwai
2019-08-08 13:02 ` Mark Brown
2019-08-08 13:14 ` Takashi Iwai
2019-08-08 13:16 ` Stefan Agner
2019-08-08 19:27 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2019-01-18 9:55 Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808123655.31520-1-stefan@agner.ch \
--to=stefan@agner.ch \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stefan.agner@toradex.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®