From: Pankaj Gupta <pagupta@redhat.com>
To: amit@kernel.org, mst@redhat.com
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
virtualization@lists.linux-foundation.org, jasowang@redhat.com,
linux-kernel@vger.kernel.org, pagupta@redhat.com,
xiaohli@redhat.com
Subject: [PATCH v3 2/2] virtio: decrement avail idx with buffer detach for packed ring
Date: Fri, 9 Aug 2019 12:18:47 +0530 [thread overview]
Message-ID: <20190809064847.28918-3-pagupta@redhat.com> (raw)
In-Reply-To: <20190809064847.28918-1-pagupta@redhat.com>
This patch decrements 'next_avail_idx' count when detaching a buffer
from vq for packed ring code. Split ring code already does this in
virtqueue_detach_unused_buf_split function. This updates the
'next_avail_idx' to the previous correct index after an unused buffer
is detatched from the vq.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
drivers/virtio/virtio_ring.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index c8be1c4f5b55..7c69181113e2 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -1537,6 +1537,12 @@ static void *virtqueue_detach_unused_buf_packed(struct virtqueue *_vq)
/* detach_buf clears data, so grab it now. */
buf = vq->packed.desc_state[i].data;
detach_buf_packed(vq, i, NULL);
+ vq->packed.next_avail_idx--;
+ if (vq->packed.next_avail_idx < 0) {
+ vq->packed.next_avail_idx = vq->packed.vring.num - 1;
+ vq->packed.avail_wrap_counter ^= 1;
+ }
+
END_USE(vq);
return buf;
}
--
2.20.1
next prev parent reply other threads:[~2019-08-09 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 6:48 [PATCH v3 0/2] virtio_console: fix replug of virtio console port Pankaj Gupta
2019-08-09 6:48 ` [PATCH v3 1/2] virtio_console: free unused buffers with port delete Pankaj Gupta
2019-08-10 18:18 ` Michael S. Tsirkin
2019-08-12 5:36 ` Pankaj Gupta
2019-08-12 9:18 ` Michael S. Tsirkin
2019-08-09 6:48 ` Pankaj Gupta [this message]
2019-08-10 18:12 ` [PATCH v3 2/2] virtio: decrement avail idx with buffer detach for packed ring Michael S. Tsirkin
2019-08-12 5:05 ` Pankaj Gupta
2019-08-12 4:46 ` Jason Wang
2019-08-12 5:37 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809064847.28918-3-pagupta@redhat.com \
--to=pagupta@redhat.com \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiaohli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®