From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720DEC433FF for ; Fri, 9 Aug 2019 21:59:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 356222089E for ; Fri, 9 Aug 2019 21:59:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XmhQBsfM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728718AbfHIV7R (ORCPT ); Fri, 9 Aug 2019 17:59:17 -0400 Received: from mail-pf1-f202.google.com ([209.85.210.202]:49044 "EHLO mail-pf1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfHIV7Q (ORCPT ); Fri, 9 Aug 2019 17:59:16 -0400 Received: by mail-pf1-f202.google.com with SMTP id u21so62302320pfn.15 for ; Fri, 09 Aug 2019 14:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=aHPozI+kRmLZ/MJlV7luwBtUMjEIFkgoeCnOJismWTA=; b=XmhQBsfMHALmx6QOLM9UBumnO7+O8bCcXOWfbEhvnKPRZtyZjK8Tox3QlWh+5SsoHo nSFWQ4AXRB5rGt1kt3KE4aQEc1I3c3lRuL9npZ/+GiDm5vL+RU7MnPYmUFcMbJyKb6ra WcTRcRm2FQ6DDaHqNyLsrOSB632i+21o8ygllWidqV7vliACQwXLx06D5cWErjUfEvvk oS6tlLYGXRIUWgi8FZPNnxObKBs0OQf/b3sPOwVn84irLt21e12rwexZf1dIbzAlT4UU pC9A8HRAZ1JoHP5xAxw+zFJ7gBhI3E9LOkogGnAloitRhXpmiawVE738kNJQ2UpHPLsi ecbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=aHPozI+kRmLZ/MJlV7luwBtUMjEIFkgoeCnOJismWTA=; b=M2Rqlf+ufzTybVB8TVyBZN3JsbUXmQr16MuQyGUgBgynKDzw9iP2SOr0UDkN9OgO0k agG301iawaRbtGNzKyfQ0d5YBAByyjeD1n4HsINOvhiTiNAOozu62sJ64Fyjpq0Q9gNN eSEZy8iSfLD/XIWCXV9Uu4EuJC+tolAF7LfDE5MetxwlPiN9k+nXxywmVxhmX6pQ1W1Z AAN1+RNGmgmuchcNDq9SxFJkWdmSl4heWNCUKHgaHHvPWNTy5isqmu9HCahNI1zlZaA5 ZWxqrxRsAm3gPIx6Z25WuD6ynFWydKFsOpxIPovFHec9FmDcupkNR6p/OhjNetVHs+x2 VBvw== X-Gm-Message-State: APjAAAV0C6B/0lhsDmi5yGpLWwpSv2q/V7uiZKPtjen0XIuddWoYnbhF B8zLXNK77eo5oT5ruAV/mtDvNpZNeA== X-Google-Smtp-Source: APXvYqyz8CcNShPWSHPO/FAxHKFz6gmTSkkw/fYF/3ATwxbLzpgLwoS9L+u1s86mqzbQrSNfPjRKv0frajw= X-Received: by 2002:a63:bf01:: with SMTP id v1mr18841445pgf.278.1565387955717; Fri, 09 Aug 2019 14:59:15 -0700 (PDT) Date: Fri, 9 Aug 2019 14:58:48 -0700 In-Reply-To: Message-Id: <20190809215848.47736-1-yabinc@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog Subject: Re: [PATCH] coresight: Serialize enabling/disabling a link device. From: Yabin Cui To: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yabin Cui Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >You may also want to protect the refcount checks below with the same lock, just >to be consistent. Good suggestion! I didn't protect it because I found other places using refcnt. But it turns out they are not link devices. I have uploaded patch v2.