From: Sam Ravnborg <sam@ravnborg.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kbuild: detect missing header include guard
Date: Sat, 10 Aug 2019 08:39:13 +0200 [thread overview]
Message-ID: <20190810063913.GB13020@ravnborg.org> (raw)
In-Reply-To: <20190728173445.10954-2-yamada.masahiro@socionext.com>
Hi Masahiro
On Mon, Jul 29, 2019 at 02:34:45AM +0900, Masahiro Yamada wrote:
> Our convention is to surround the whole of the header content with an
> include guard. This avoids the same header being parsed over again in
> case it is included multiple times.
>
> The include guard is missing in several places, or broken due to the
> mismatch between #ifndef and #define.
>
> The recently added header-test-y syntax allows the comprehensive sanity
> checks of headers. This commit adds another check; if include guard is
> missing, the header will fail to build due to redefinition of something.
>
> Some headers must be excluded from the test-coverage for now. I will
> let them in after they are fixed.
Smart and simple - nice.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Sam
next prev parent reply other threads:[~2019-08-10 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 17:34 [PATCH 1/2] kbuild: stop compile-testing kernel headers by wildcard patterns Masahiro Yamada
2019-07-28 17:34 ` [PATCH 2/2] kbuild: detect missing header include guard Masahiro Yamada
2019-08-10 6:39 ` Sam Ravnborg [this message]
2019-08-10 6:37 ` [PATCH 1/2] kbuild: stop compile-testing kernel headers by wildcard patterns Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190810063913.GB13020@ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®