mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org,
	jank@cadence.com, srinivas.kandagatla@linaro.org,
	slawomir.blauciak@intel.com,
	Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH 2/3] soundwire: cadence_master: add debugfs register dump
Date: Sat, 10 Aug 2019 09:03:08 +0200	[thread overview]
Message-ID: <20190810070308.GB6896@kroah.com> (raw)
In-Reply-To: <20190809224341.15726-3-pierre-louis.bossart@linux.intel.com>

On Fri, Aug 09, 2019 at 05:43:40PM -0500, Pierre-Louis Bossart wrote:
> +/**
> + * sdw_cdns_debugfs_init() - Cadence debugfs init
> + * @cdns: Cadence instance
> + * @root: debugfs root
> + */
> +void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root)
> +{
> +	debugfs_create_file("cdns-registers", 0400, root, cdns, &cdns_reg_fops);
> +}
> +EXPORT_SYMBOL_GPL(sdw_cdns_debugfs_init);

You create this function but never actually call it.  Don't add apis
that no one uses :(

thanks,

greg k-h

  reply	other threads:[~2019-08-10  7:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 22:43 [PATCH 0/3] soundwire: debugfs support for 5.4 Pierre-Louis Bossart
2019-08-09 22:43 ` [PATCH 1/3] soundwire: add debugfs support Pierre-Louis Bossart
2019-08-10  7:01   ` Greg KH
2019-08-12 13:24     ` [alsa-devel] " Pierre-Louis Bossart
2019-08-09 22:43 ` [PATCH 2/3] soundwire: cadence_master: add debugfs register dump Pierre-Louis Bossart
2019-08-10  7:03   ` Greg KH [this message]
2019-08-12 13:32     ` [alsa-devel] " Pierre-Louis Bossart
2019-08-09 22:43 ` [PATCH 3/3] soundwire: intel: " Pierre-Louis Bossart
2019-08-10  7:03   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190810070308.GB6896@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jank@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=slawomir.blauciak@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®