From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C70AC41514 for ; Mon, 12 Aug 2019 12:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB87E214C6 for ; Mon, 12 Aug 2019 12:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="kG4XT2lK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728397AbfHLMLs (ORCPT ); Mon, 12 Aug 2019 08:11:48 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:46923 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbfHLMLr (ORCPT ); Mon, 12 Aug 2019 08:11:47 -0400 Received: by mail-ed1-f66.google.com with SMTP id z51so16019995edz.13 for ; Mon, 12 Aug 2019 05:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hujPz5MzKCPbinmOqr53v4vBoAK56yuLqnChSDEz9qA=; b=kG4XT2lKey+4eCUsbMw608+JUTWj1lxYAaeWUpvWhAU4mfmvKO1+mJ2RbJ/TTwzVWz EosPGa6L2PH3pvSfpx2JB3jPONr6bQWPR8QPHlKo7gBcN5HJgvlFlZkahclBPmY5SPza u9cvzhY3lYXcLrHIpUBRonwmDzBcOdQxD8gYB019tPz4aEzzNpPnkmP9BbhoChr5mPzG Qb+3Y9e3MgNaPVnkEkafCYsctwGpOnfIdg90xtn6RsEvJbL5V5x/iyZa/eWrEg7UY7Cl b44oBsJHgNUel8LwWzX1ouV8n4wDh8pr89cI5bGwPB29mD6ThSDApXkIpV5tWesvpRxj YZFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hujPz5MzKCPbinmOqr53v4vBoAK56yuLqnChSDEz9qA=; b=t/+cUv4UHV/I62nFAyfit0dW7dGHmudwMad+HdMba5eKQhMQXbF9v8lD+Q+ZWLj4w+ lsReAfFlJHNT/c+S53zrvgfmfu/UDEDlgKdv9cX3UhLNZ9d77GHcw5bvmWUnf9wiH70b 34ikQr1wdabCh/Rf7qNZO3gkdWRtDVcvC0N9edoXuJ3JDkcsH1ABoPg/l5wzsyWvtJUA we6lLpgbUvAwtOLKY6EBsW+kycgZG/tdU3b2/urWpAlFEZmQfSTAbVM5NI2kcsyuX7qW CTL0+qTKmiYazz2jKvUmL3M0hJ7yz16p3f7WQzcSou/QVClpkaDc2UvZRBmDSrPquGFN WxsA== X-Gm-Message-State: APjAAAVC7PPEsP41VuXa1wOq1NKi682MMc8WIVIp8aM6OxO8GL8dBjVF xUu1ubxZjYe6Ai7dLpukiWVfow== X-Google-Smtp-Source: APXvYqwghgOTyS9rkCUVPgJV5+8qxWl9q0SIGpjg1BJW8yOQj7jdU3JnAfDL4hy0NKzKdkKqkGV/sw== X-Received: by 2002:a17:906:e088:: with SMTP id gh8mr6556500ejb.117.1565611905926; Mon, 12 Aug 2019 05:11:45 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id x11sm17492035eju.26.2019.08.12.05.11.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 05:11:45 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id DC616100854; Mon, 12 Aug 2019 15:11:44 +0300 (+03) Date: Mon, 12 Aug 2019 15:11:44 +0300 From: "Kirill A. Shutemov" To: Song Liu Cc: Oleg Nesterov , Linux Kernel Mailing List , Linux MM , Andrew Morton , Matthew Wilcox , "Kirill A. Shutemov" , Kernel Team , William Kucharski , "srikar@linux.vnet.ibm.com" Subject: Re: [PATCH v12 5/6] khugepaged: enable collapse pmd for pte-mapped THP Message-ID: <20190812121144.f46abvpg6lvxwwzs@box> References: <20190807233729.3899352-1-songliubraving@fb.com> <20190807233729.3899352-6-songliubraving@fb.com> <20190808163303.GB7934@redhat.com> <770B3C29-CE8F-4228-8992-3C6E2B5487B6@fb.com> <20190809152404.GA21489@redhat.com> <3B09235E-5CF7-4982-B8E6-114C52196BE5@fb.com> <4D8B8397-5107-456B-91FC-4911F255AE11@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D8B8397-5107-456B-91FC-4911F255AE11@fb.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 09, 2019 at 06:01:18PM +0000, Song Liu wrote: > + if (pte_none(*pte) || !pte_present(*pte)) > + continue; You don't need to check both. Present is never none. -- Kirill A. Shutemov