From: Pankaj Gupta <pagupta@redhat.com>
To: mst@redhat.com, amit@kernel.org
Cc: virtualization@lists.linux-foundation.org, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
jasowang@redhat.com, pagupta@redhat.com
Subject: [PATCH v4 0/2] virtio_console: fix replug of virtio console port
Date: Tue, 13 Aug 2019 19:35:27 +0530 [thread overview]
Message-ID: <20190813140529.12939-1-pagupta@redhat.com> (raw)
This patch series fixes the issue with unplug/replug of a port in virtio
console driver which fails with an error "Error allocating inbufs\n".
Patch 1 updates the next avail index for packed ring code.
Patch 2 makes use of 'virtqueue_detach_unused_buf' function to detach
the unused buffers during port hotunplug time.
Tested the packed ring code with the qemu virtio 1.1 device code posted
here [1]. Also, sent a patch to document the behavior in virtio spec as
suggested by Michael.
Changes from v3
- Swap patch 1 with patch 2 - [Michael]
- Added acked-by tag by Jason in patch 1
- Add reference to spec change
Changes from v2
- Better change log in patch2 - [Greg]
Changes from v1[2]
- Make virtio packed ring code compatible with split ring - [Michael]
[1] https://marc.info/?l=qemu-devel&m=156471883703948&w=2
[2] https://lkml.org/lkml/2019/3/4/517
[3] https://lists.oasis-open.org/archives/virtio-dev/201908/msg00055.html
Pankaj Gupta (2):
virtio: decrement avail idx with buffer detach for packed ring
virtio_console: free unused buffers with port delete
char/virtio_console.c | 14 +++++++++++---
virtio/virtio_ring.c | 6 ++++++
2 files changed, 17 insertions(+), 3 deletions(-)
--
2.21.0
next reply other threads:[~2019-08-13 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 14:05 Pankaj Gupta [this message]
2019-08-13 14:05 ` [PATCH v4 1/2] virtio: decrement avail idx with buffer detach for packed ring Pankaj Gupta
2019-08-13 14:05 ` [PATCH v4 2/2] virtio_console: free unused buffers with port delete Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813140529.12939-1-pagupta@redhat.com \
--to=pagupta@redhat.com \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®