From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B10C433FF for ; Wed, 14 Aug 2019 04:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D0012084D for ; Wed, 14 Aug 2019 04:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565755268; bh=KjGrHL3n1w6JAxO6p8Ca0jjy6JRrEniuOLnYntqmCG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hx8TVOX1ysUosJfxEN7+vUITxOIZsGhpKEy5ow5iUMgDYe8lISgBfm2SPYOTFGfLH jT8bHLUOL6nuNPXFZ41fZrv4AFTBJNu8uhDzzyu2e0MMbqhPONZOy5sG9V1AWklEJ5 pOHIC+3H5i/K5jh2TRXSApodclM9sFVxOPRX9Baw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbfHNEBH (ORCPT ); Wed, 14 Aug 2019 00:01:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:46684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725262AbfHNEBH (ORCPT ); Wed, 14 Aug 2019 00:01:07 -0400 Received: from localhost (unknown [106.51.111.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C3262083B; Wed, 14 Aug 2019 04:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565755265; bh=KjGrHL3n1w6JAxO6p8Ca0jjy6JRrEniuOLnYntqmCG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ONnlQGzsDHaZJiA2scjuNH9O0USpNDO8H5fBeieKfzd62tzRnCLZRfClpKloYexhC JTe+tt1VBfK9HlRdchAkZptcmFkpy+LgzmBQBkCV0BkrOLWrVJHuZteA1Nnn5JLFf7 eZXb3AkHvZ1RDMUgS4VSWEpTMJj+dWrtj6QCKu3g= Date: Wed, 14 Aug 2019 09:29:47 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: Nathan Chancellor , Sanyog Kale , clang-built-linux@googlegroups.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] soundwire: Don't build sound.o without CONFIG_ACPI Message-ID: <20190814035947.GS12733@vkoul-mobl.Dlink> References: <20190813061014.45015-1-natechancellor@gmail.com> <445d16e1-6b00-6797-82df-42a49a5e79e3@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <445d16e1-6b00-6797-82df-42a49a5e79e3@linux.intel.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-08-19, 09:22, Pierre-Louis Bossart wrote: > On 8/13/19 1:10 AM, Nathan Chancellor wrote: > > clang warns when CONFIG_ACPI is unset: > > > > ../drivers/soundwire/slave.c:16:12: warning: unused function > > 'sdw_slave_add' [-Wunused-function] > > static int sdw_slave_add(struct sdw_bus *bus, > > ^ > > 1 warning generated. > > > > Before commit 8676b3ca4673 ("soundwire: fix regmap dependencies and > > align with other serial links"), this code would only be compiled when > > ACPI was set because it was only selected by SOUNDWIRE_INTEL, which > > depends on ACPI. > > > > Now, this code can be compiled without CONFIG_ACPI, which causes the > > above warning. The IS_ENABLED(CONFIG_ACPI) guard could be moved to avoid > > compiling the function; however, slave.c only contains three functions, > > two of which are static. Only compile slave.o when CONFIG_ACPI is set, > > where it will actually be used. bus.h contains a stub for > > sdw_acpi_find_slaves so there will be no issues with an undefined > > function. > > > > This has been build tested with CONFIG_ACPI set and unset in combination > > with CONFIG_SOUNDWIRE unset, built in, and a module. > > Thanks for the patch. Do you have a .config you can share offline so that we > add it to our tests? > > > > > Fixes: 8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links") > > Link: https://github.com/ClangBuiltLinux/linux/issues/637 > > Signed-off-by: Nathan Chancellor > > --- > > drivers/soundwire/Makefile | 6 +++++- > > drivers/soundwire/slave.c | 3 --- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile > > index 45b7e5001653..226090902716 100644 > > --- a/drivers/soundwire/Makefile > > +++ b/drivers/soundwire/Makefile > > @@ -4,9 +4,13 @@ > > # > > #Bus Objs > > -soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o > > +soundwire-bus-objs := bus_type.o bus.o mipi_disco.o stream.o > > obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o > > +ifdef CONFIG_ACPI > > +soundwire-bus-objs += slave.o > > +endif > > I am fine with the change, but we might as well rename the file acpi_slave.c > then? Srini's change add support for DT for the same file, so It does not make sense to rename. Yes this patch tries to fix a warn which is there due to DT being not supported but with Srini's patches this warn should go away as sdw_slave_add() will be invoked by the DT counterpart Sorry Nathan, we would have to live with the warn for few more days till I apply Srini's changes. So I am not taking this (or v2) patch Thanks > > > + > > #Cadence Objs > > soundwire-cadence-objs := cadence_master.o > > obj-$(CONFIG_SOUNDWIRE_CADENCE) += soundwire-cadence.o > > diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c > > index f39a5815e25d..0dc188e6873b 100644 > > --- a/drivers/soundwire/slave.c > > +++ b/drivers/soundwire/slave.c > > @@ -60,7 +60,6 @@ static int sdw_slave_add(struct sdw_bus *bus, > > return ret; > > } > > -#if IS_ENABLED(CONFIG_ACPI) > > /* > > * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node > > * @bus: SDW bus instance > > @@ -110,5 +109,3 @@ int sdw_acpi_find_slaves(struct sdw_bus *bus) > > return 0; > > } > > - > > -#endif > > -- ~Vinod