From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F2F0C32753 for ; Wed, 14 Aug 2019 09:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD1762083B for ; Wed, 14 Aug 2019 09:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565774537; bh=SSG5SsTgRz8aknwV+vEeWON9FnHe2hziZgnl35xjJZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vzgpxvzNZ0W7kbJudFNmGAK7tMup+cE48lIZFiCSlW40l/46BqK9XCKizI9AGKadj T7QS2roCGdEs31i1bw589LSJbg87dx4/quy/DoWRIrJ7KuKe9n+Ip0ro8kwdr4cT0v jogfx3STufbiVULz0r5PFqmOYPcArZpc/MpQAazI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbfHNJWQ (ORCPT ); Wed, 14 Aug 2019 05:22:16 -0400 Received: from mail-wm1-f98.google.com ([209.85.128.98]:52618 "EHLO mail-wm1-f98.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726019AbfHNJWQ (ORCPT ); Wed, 14 Aug 2019 05:22:16 -0400 Received: by mail-wm1-f98.google.com with SMTP id o4so3798621wmh.2 for ; Wed, 14 Aug 2019 02:22:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SSG5SsTgRz8aknwV+vEeWON9FnHe2hziZgnl35xjJZc=; b=cvpZVnScBBAN+w3tCtW/dQhXUJttYL0hauvFrUxn8tPjf7VrZeYYOdFUH4H1Y9WovX +DE/Msi+VyTjlpB7fJX70W6GeQ2/+lYSOpHX55jpbDV/2BAxTNJC7IEaSA6XTtfXc3GY jXuqdX+r4y0ZLH79+4OTu+05ZzMbjn5bpkvNW99Kb/c1aUfUb5+/gLnhRRNBVi08uXL2 aU3NsjOI5WjcknGtY39VWSQtjSZCQLQrESYM2MDqDp1RaewkFgA4FvXfEOHPgPT4pNK2 kFCsm5pp8A71bF6pkkt3shGw8YOPNlk9tN9hItXwufXRMroSrK4Qpue/Dtylx670Js9c KxBA== X-Gm-Message-State: APjAAAXtIa58RI8s/KCNii4DeMcd3afMmviZ9DEVLsWy4q+VnniGWwJS 6d/X1QHKnopSrHp9t61hoLs2fhh5QXqbfqsTuoDCVp9F3TjKU1jPrkZsCASCQ4C2Yg== X-Google-Smtp-Source: APXvYqwk1pZdmTm8xzObKTTZgelMb2/Nqjd7ldXvP8RIGZSwCBDfeOtAx9e281abWnZfBAflakFtD5GOtPIa X-Received: by 2002:a1c:6782:: with SMTP id b124mr5525568wmc.143.1565774534331; Wed, 14 Aug 2019 02:22:14 -0700 (PDT) Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk. [2a01:7e01::f03c:91ff:fed4:a3b6]) by smtp-relay.gmail.com with ESMTPS id m2sm33363wmg.0.2019.08.14.02.22.14 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 02:22:14 -0700 (PDT) X-Relaying-Domain: sirena.org.uk Received: from ypsilon.sirena.org.uk ([2001:470:1f1d:6b5::7]) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hxpTy-0004dk-2r; Wed, 14 Aug 2019 09:22:14 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 737A12742B4F; Wed, 14 Aug 2019 10:22:13 +0100 (BST) Date: Wed, 14 Aug 2019 10:22:13 +0100 From: Mark Brown To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ricard Wanderlof , Ricard Wanderlof Subject: Re: [PATCH AUTOSEL 5.2 040/123] ASoC: Fail card instantiation if DAI format setup fails Message-ID: <20190814092213.GC4640@sirena.co.uk> References: <20190814021047.14828-1-sashal@kernel.org> <20190814021047.14828-40-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f0KYrhQ4vYSV2aJu" Content-Disposition: inline In-Reply-To: <20190814021047.14828-40-sashal@kernel.org> X-Cookie: Bridge ahead. Pay troll. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --f0KYrhQ4vYSV2aJu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 13, 2019 at 10:09:24PM -0400, Sasha Levin wrote: > From: Ricard Wanderlof >=20 > [ Upstream commit 40aa5383e393d72f6aa3943a4e7b1aae25a1e43b ] >=20 > If the DAI format setup fails, there is no valid communication format > between CPU and CODEC, so fail card instantiation, rather than continue > with a card that will most likely not function properly. This is another one where if nobody noticed a problem already and things just happened to be working this might break things, it's vanishingly unlikely to fix anything that was broken. --f0KYrhQ4vYSV2aJu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1T0sQACgkQJNaLcl1U h9Dlhgf/SR61ZIrJGolkp7rFvrAe5gVGCY1dA1YOv8xsh+klKIFA/mYQygTalGzO vdEeVShGrPlbSXr4LKkOF97cB1Reflot2WD9jPjVPN509G/Kw01cI63Zh4fPco7q UebertPWgV6fJqMNBwOv8ecLpF1dvtfyTt7APxEQx1Qgj3JIcXY0n2oRVQzHVnRF QQBP5i2uCsqbyqJmcMMbYTwyXmETLFKbZZcl/JHcKayztlZSW4pvIG9nhtqQctZ8 Rl551stNHaRmcPn59Y6DcLSyt46MQoA+U3kndIp+hJS89MCcv+4iGfZ+OoSX1cJ8 kv8hFunAg3CxrcC7CPQxRYIAbzLcpw== =PJBh -----END PGP SIGNATURE----- --f0KYrhQ4vYSV2aJu--