From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D90C32753 for ; Thu, 15 Aug 2019 00:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25C292171F for ; Thu, 15 Aug 2019 00:11:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="g0iXAp9G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbfHOALk (ORCPT ); Wed, 14 Aug 2019 20:11:40 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:38023 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728373AbfHOALj (ORCPT ); Wed, 14 Aug 2019 20:11:39 -0400 Received: by mail-qt1-f194.google.com with SMTP id x4so660335qts.5 for ; Wed, 14 Aug 2019 17:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=sa+zQVwF/Kg2yH2R3qjmRo+nBMZgWEgWy9VtHzhObIQ=; b=g0iXAp9GLKjmJUCykogXNEfQUbyHV9nCucIjUntdM1KKe6wGTXBPlF2UOoTWZOGfJl AmajYGKP63nxK6g4uAQuCBhnJ9E6JBx7+PoQJl4H925pXAjlhGkj572kQrS2NActiipP kxwRxIXOfJDm8mccWD6WHhV9xJyTZoODJcRJWpuRBg9qbQQk4EiIxDhaFEh+gSkvInRl wmPRmh/bNa5dNbX8qh2MmqKpcoUwYdco5Q1f/jvTQoW1q8UlyeXxKNaG6oETdo4lI4Kt Lzy3yHCgAJpdYNwrpVyOegXvj1unwKdFwN8pNkz4YjlDTDEUIixQQUpKRN+VZGMEPnlq qHLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=sa+zQVwF/Kg2yH2R3qjmRo+nBMZgWEgWy9VtHzhObIQ=; b=hnupdlRtyqr9NsACncvI7nDapGlJioizRrWtcYddFqUycbVI29AXqsSktlc/dxogw7 evbcOBb5LhNWFaZvfohfkQDrfhyzcp6SkcdRLklFWsp5MC5DXlGDy1T6+FpuhMxFpOkg 0QrgK0AnydVSgEVQRKRU2VjTl/zoMSp2qIxXVVL+z2ouVjGEAbdwyPEeDviGZO/QTfoS 7O+kwtnj8RVbxMCAkXwZhjkP5L+AejxBTkPJLG9UBzMc2XvBNVq2A4zJZjZyXf+psou6 fY8Gq79HN9+UJa3lPCI4X3luj+Ud5je7AmRBHYxwkJfrI8epzHrByXPcJKom5CuzJT1O 3fBQ== X-Gm-Message-State: APjAAAUHv9hNfDLHnokF+48nzy09z0vTXmyGgQpGZNN3GvObvgW7daSE XP5/VUB0OIPWWZmzhXiiQhO6Jg== X-Google-Smtp-Source: APXvYqycoMish4JR7Yhk7POc91EfS5nVJ1Ns5md0NOId7Ywyc7vJCJUYwUMZE0JVH6XYbdhlVPx8eg== X-Received: by 2002:ad4:45e3:: with SMTP id q3mr1591887qvu.140.1565827898756; Wed, 14 Aug 2019 17:11:38 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id f20sm939480qtf.68.2019.08.14.17.11.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Aug 2019 17:11:38 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hy3Mf-0003aK-TC; Wed, 14 Aug 2019 21:11:37 -0300 Date: Wed, 14 Aug 2019 21:11:37 -0300 From: Jason Gunthorpe To: Daniel Vetter Cc: LKML , linux-mm@kvack.org, DRI Development , Intel Graphics Development , Ralph Campbell , John Hubbard , Dan Williams , Dan Carpenter , Matthew Wilcox , Arnd Bergmann , Balbir Singh , Ira Weiny , Souptick Joarder , Andrew Morton , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Daniel Vetter Subject: Re: [PATCH 5/5] mm/hmm: WARN on illegal ->sync_cpu_device_pagetables errors Message-ID: <20190815001137.GE11200@ziepe.ca> References: <20190814202027.18735-1-daniel.vetter@ffwll.ch> <20190814202027.18735-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190814202027.18735-6-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2019 at 10:20:27PM +0200, Daniel Vetter wrote: > Similar to the warning in the mmu notifer, warning if an hmm mirror > callback gets it's blocking vs. nonblocking handling wrong, or if it > fails with anything else than -EAGAIN. > > Cc: Jason Gunthorpe > Cc: Ralph Campbell > Cc: John Hubbard > Cc: Dan Williams > Cc: Dan Carpenter > Cc: Matthew Wilcox > Cc: Arnd Bergmann > Cc: Balbir Singh > Cc: Ira Weiny > Cc: Souptick Joarder > Cc: Andrew Morton > Cc: "Jérôme Glisse" > Cc: linux-mm@kvack.org > Signed-off-by: Daniel Vetter > mm/hmm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/hmm.c b/mm/hmm.c > index 16b6731a34db..52ac59384268 100644 > +++ b/mm/hmm.c > @@ -205,6 +205,9 @@ static int hmm_invalidate_range_start(struct mmu_notifier *mn, > ret = -EAGAIN; > break; > } > + WARN(ret, "%pS callback failed with %d in %sblockable context\n", > + mirror->ops->sync_cpu_device_pagetables, ret, > + update.blockable ? "" : "non-"); > } > up_read(&hmm->mirrors_sem); Didn't I beat you to this? list_for_each_entry(mirror, &hmm->mirrors, list) { int rc; rc = mirror->ops->sync_cpu_device_pagetables(mirror, &update); if (rc) { if (WARN_ON(update.blockable || rc != -EAGAIN)) continue; ret = -EAGAIN; break; } } Thanks, Jason