From: Christoph Hellwig <hch@lst.de>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>
Cc: Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <alistair.francis@wdc.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] drm/amdgpu: handle PCIe root ports with addressing limitations
Date: Thu, 15 Aug 2019 09:27:01 +0200 [thread overview]
Message-ID: <20190815072703.7010-3-hch@lst.de> (raw)
In-Reply-To: <20190815072703.7010-1-hch@lst.de>
amdgpu uses a need_dma32 flag to indicate to the drm core that some
allocations need to be done using GFP_DMA32, but it only checks the
device addressing capabilities to make that decision. Unfortunately
PCIe root ports that have limited addressing exist as well. Use the
dma_addressing_limited instead to also take those into account.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index e51b48ac48eb..91f128b43b6a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -1728,7 +1728,7 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
r = ttm_bo_device_init(&adev->mman.bdev,
&amdgpu_bo_driver,
adev->ddev->anon_inode->i_mapping,
- adev->need_dma32);
+ dma_addressing_limited(adev->dev));
if (r) {
DRM_ERROR("failed initializing buffer object driver(%d).\n", r);
return r;
--
2.20.1
next prev parent reply other threads:[~2019-08-15 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 7:26 fix radeon and amdgpu for addressing limited root ports Christoph Hellwig
2019-08-15 7:27 ` [PATCH 1/4] drm/radeon: handle PCIe root ports with addressing limitations Christoph Hellwig
2019-08-15 8:34 ` Koenig, Christian
2019-08-15 10:06 ` Christoph Hellwig
2019-08-15 14:15 ` Alex Deucher
2019-08-15 14:29 ` Koenig, Christian
2019-08-15 7:27 ` Christoph Hellwig [this message]
2019-08-15 7:27 ` [PATCH 3/4] drm/radeon: simplify and cleanup setting the dma mask Christoph Hellwig
2019-08-15 7:27 ` [PATCH 4/4] drm/amdgpu: " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815072703.7010-3-hch@lst.de \
--to=hch@lst.de \
--cc=Atish.Patra@wdc.com \
--cc=David1.Zhou@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alistair.francis@wdc.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®