mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Chuhong Yuan <hslester96@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix
Date: Thu, 15 Aug 2019 16:50:33 +0900	[thread overview]
Message-ID: <20190815075033.GA26479@tigerII.localdomain> (raw)
In-Reply-To: <20190814104941.qt66ozcau5fdswcs@pathway.suse.cz>

On (08/14/19 12:49), Petr Mladek wrote:
> On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote:
> > strncmp(str, const, len) is error-prone because len
> > is easy to have typo.
> > The example is the hard-coded len has counting error
> > or sizeof(const) forgets - 1.
> > So we prefer using newly introduced str_has_prefix()
> > to substitute such strncmp to make code better.
> > 
> > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

Reviewed-by:  Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

  reply	other threads:[~2019-08-15  7:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  7:10 Chuhong Yuan
2019-08-14 10:49 ` Petr Mladek
2019-08-15  7:50   ` Sergey Senozhatsky [this message]
2019-08-15 13:52     ` Petr Mladek
2019-08-15 15:33       ` Chuhong Yuan
2019-08-16  8:27         ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190815075033.GA26479@tigerII.localdomain \
    --to=sergey.senozhatsky@gmail.com \
    --cc=hslester96@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®