From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Jia He <justin.he@arm.com>
Cc: Petr Mladek <pmladek@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>, Shuah Khan <shuah@kernel.org>,
"Tobin C. Harding" <tobin@kernel.org>
Subject: Re: [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid pointers for %pD
Date: Thu, 15 Aug 2019 16:52:06 +0900 [thread overview]
Message-ID: <20190815075206.GB26479@tigerII.localdomain> (raw)
In-Reply-To: <20190809012457.56685-1-justin.he@arm.com>
On (08/09/19 09:24), Jia He wrote:
> Commit 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing invalid
> pointers") prevents most crash except for %pD.
> There is an additional pointer dereferencing before dentry_name.
>
> At least, vma->file can be NULL and be passed to printk %pD in
> print_bad_pte, which can cause crash.
>
> This patch fixes it with introducing a new file_dentry_name.
>
> Signed-off-by: Jia He <justin.he@arm.com>
The series looks OK to me.
FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
prev parent reply other threads:[~2019-08-15 7:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 1:24 Jia He
2019-08-09 1:24 ` [PATCH 2/2] lib/test_printf: add test of null/invalid pointer dereference for dentry Jia He
2019-08-09 10:51 ` Andy Shevchenko
2019-08-16 8:26 ` Petr Mladek
2019-08-16 8:31 ` Justin He (Arm Technology China)
2019-08-09 10:51 ` [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid pointers for %pD Andy Shevchenko
2019-08-09 10:56 ` Justin He (Arm Technology China)
2019-08-16 8:20 ` Petr Mladek
2019-08-15 7:52 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815075206.GB26479@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=justin.he@arm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®