From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85645C3A589 for ; Thu, 15 Aug 2019 13:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5596F206C1 for ; Thu, 15 Aug 2019 13:48:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732502AbfHONsm (ORCPT ); Thu, 15 Aug 2019 09:48:42 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:55129 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732122AbfHONsl (ORCPT ); Thu, 15 Aug 2019 09:48:41 -0400 X-Originating-IP: 87.5.130.64 Received: from uno.localdomain (host64-130-dynamic.5-87-r.retail.telecomitalia.it [87.5.130.64]) (Authenticated sender: jacopo@jmondi.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3A0D440004; Thu, 15 Aug 2019 13:48:38 +0000 (UTC) Date: Thu, 15 Aug 2019 15:50:04 +0200 From: Jacopo Mondi To: Hans Verkuil Cc: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , open list Subject: Re: [RFC 3/5] media: v4l2-ctrls: Add support for V4L2_CID_LOCATION Message-ID: <20190815135004.7o57rff4ce5sb5bb@uno.localdomain> References: <20190814202815.32491-1-jacopo@jmondi.org> <20190814202815.32491-4-jacopo@jmondi.org> <20190814225353.GE5015@pendragon.ideasonboard.com> <20190815130245.usat55oqffe4abvi@uno.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sygdstqlfcrskvaa" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sygdstqlfcrskvaa Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Hans, On Thu, Aug 15, 2019 at 03:41:53PM +0200, Hans Verkuil wrote: > On 8/15/19 3:02 PM, Jacopo Mondi wrote: > > Hi Laurent, > > > > On Thu, Aug 15, 2019 at 01:53:53AM +0300, Laurent Pinchart wrote: > >> Hi Jacopo, > >> > >> Thank you for the patch. > >> > >> On Wed, Aug 14, 2019 at 10:28:13PM +0200, Jacopo Mondi wrote: > >>> Add support for the newly defined V4L2_CID_LOCATION read-only control > >>> used to report the camera device mounting position. > >>> > >>> Signed-off-by: Jacopo Mondi > >>> --- > >>> drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++++++ > >>> include/uapi/linux/v4l2-controls.h | 4 ++++ > >>> 2 files changed, 11 insertions(+) > >>> > >>> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c > >>> index 7d3a33258748..8ab0857df59a 100644 > >>> --- a/drivers/media/v4l2-core/v4l2-ctrls.c > >>> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > >>> @@ -943,6 +943,7 @@ const char *v4l2_ctrl_get_name(u32 id) > >>> case V4L2_CID_AUTO_FOCUS_RANGE: return "Auto Focus, Range"; > >>> case V4L2_CID_PAN_SPEED: return "Pan, Speed"; > >>> case V4L2_CID_TILT_SPEED: return "Tilt, Speed"; > >>> + case V4L2_CID_LOCATION: return "Location"; > >> > >> Depending on what we decide to name the control (see review of 2/5), you > >> should adjust the description accordingly. > >> > >>> > >>> /* FM Radio Modulator controls */ > >>> /* Keep the order of the 'case's the same as in v4l2-controls.h! */ > >>> @@ -1300,6 +1301,12 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > >>> break; > >>> case V4L2_CID_MPEG_VIDEO_FWHT_PARAMS: > >>> *type = V4L2_CTRL_TYPE_FWHT_PARAMS; > >>> + case V4L2_CID_LOCATION: > >>> + *type = V4L2_CTRL_TYPE_INTEGER; > >>> + *flags |= V4L2_CTRL_FLAG_READ_ONLY; > >>> + *min = V4L2_LOCATION_FRONT; > >>> + *max = V4L2_LOCATION_BACK; > >> > >> I don't think the control should have a min and a max different than the > >> current value, as it's a fully static control. I'd drop those two lines > >> here, and drivers will have to set value = min = max = V4L2_LOCATION_xxx > >> when creating the control. That why you should be able to collapse this > >> with V4L2_CID_MIN_BUFFERS_FOR_OUTPUT. > >> > > > > Ah, I thought min/max should report the actual control values limits. > > Anyway, if we move this to be an integer menu control with an helper > > to parse the DT property and register the control on behalf of > > drivers, this will change. > > > >>> + *step = 1; > >>> break; > >>> default: > >>> *type = V4L2_CTRL_TYPE_INTEGER; > >>> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > >>> index 37807f23231e..5c4c7b245921 100644 > >>> --- a/include/uapi/linux/v4l2-controls.h > >>> +++ b/include/uapi/linux/v4l2-controls.h > >>> @@ -889,6 +889,10 @@ enum v4l2_auto_focus_range { > >>> #define V4L2_CID_PAN_SPEED (V4L2_CID_CAMERA_CLASS_BASE+32) > >>> #define V4L2_CID_TILT_SPEED (V4L2_CID_CAMERA_CLASS_BASE+33) > >>> > >>> +#define V4L2_CID_LOCATION (V4L2_CID_CAMERA_CLASS_BASE+34) > >>> +#define V4L2_LOCATION_FRONT (0 << 0) > >>> +#define V4L2_LOCATION_BACK (1 << 0) > >> > >> Why not just 0 and 1 ? > > > > Or why not BIT(). I saw that the (1 << x) style is the mostly used one in > > this header file when defining macros like this one so I went for > > consistency with the existing code. > > Definitely not right. This is an enumeration, so just number from 0, 1, 2, ... > > Nothing to do with bits/bitmasks. Aren't these enumerations too? #define V4L2_CID_3A_LOCK (V4L2_CID_CAMERA_CLASS_BASE+27) #define V4L2_LOCK_EXPOSURE (1 << 0) #define V4L2_LOCK_WHITE_BALANCE (1 << 1) #define V4L2_LOCK_FOCUS (1 << 2) #define V4L2_CID_AUTO_FOCUS_START (V4L2_CID_CAMERA_CLASS_BASE+28) #define V4L2_CID_AUTO_FOCUS_STOP (V4L2_CID_CAMERA_CLASS_BASE+29) #define V4L2_CID_AUTO_FOCUS_STATUS (V4L2_CID_CAMERA_CLASS_BASE+30) #define V4L2_AUTO_FOCUS_STATUS_IDLE (0 << 0) #define V4L2_AUTO_FOCUS_STATUS_BUSY (1 << 0) #define V4L2_AUTO_FOCUS_STATUS_REACHED (1 << 1) #define V4L2_AUTO_FOCUS_STATUS_FAILED (1 << 2) Anyway, I'm happy to change them to plain numbers. > > Regards, > > Hans > > > > >> > >>> + > >>> /* FM Modulator class control IDs */ > >>> > >>> #define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) > >> > >> -- > >> Regards, > >> > >> Laurent Pinchart > --sygdstqlfcrskvaa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtcQ9SICaIIqPWDjAcjQGjxahVjwFAl1VYwwACgkQcjQGjxah VjwbUQ//SZU8W3k2vP2RA/vHSegQjAPM6EWP/6/BeoZ+lHIPgA/kJeGJIjvy5vqx qQc/oHMx83DwgBwVKIOV3wLYmZ7pl7r2VpYGhJ6f8Eptirx90NdGNYA/8YitVNBi kxn5u0jggtERyzsF3sBWvjw4moMjedf9y56VVsaOdoc3SDr4gZC4kx+GBPw4pIwW yJiJDSycVfhaivatUpZ9Zo+Ac0plPN3koT7DuUzKyUH2TwjGcAyCY5m7bLMx1A+Y 0VGZrMCTfDyrN5Y9v/XV+MZ4KG+sp7NqjxulTQo1vGuIba6+9Nd85ozO9hxf+sGu W0hvFDd9TvEtaDgAJl4vrh0r9Ghjb7FD8roHaKlJcbSjqNqivFuyYLNYzLY5REa6 9o+8KeZGvaiafiUr5GOC1+r85qofo/KlXmisPJWxka1j/DgS/AkSKE/Tom2/1Xhw MKlC7Ti/JECzPLkeRTNjCAoJ9LAotvgMS4J4jaK+podlMp0T/y1VpADoFW7vN98h d6u2/+nl51Ha4BDJpYJG5sHmOkNUQvMRXcikk8OhKUEfV/jxki95ZH03kHd/owHS 3s1ImlIpFUTnMZ3UIurof2E7AH9ATnB3xgtm//qTGB/fakYq5n4XCQn/g1XtivNH FjM72/6tebX98Kxh8PY5zAdHu8046SoInrCstUOd8hPPk1REYFY= =Qbun -----END PGP SIGNATURE----- --sygdstqlfcrskvaa--