From: Nathan Huckleberry <nhuck@google.com>
To: yamada.masahiro@socionext.com, michal.lkml@markovi.net,
joe@perches.com, miguel.ojeda.sandonis@gmail.com
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Nathan Huckleberry <nhuck@google.com>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH v2] kbuild: Require W=1 for -Wimplicit-fallthrough with clang
Date: Thu, 15 Aug 2019 15:58:44 -0700 [thread overview]
Message-ID: <20190815225844.145726-1-nhuck@google.com> (raw)
In-Reply-To: <CAKwvOdk+NQCKZ4EXAukaKYK4R9CDaNWVY_aDxXaeQrLfo_Z=nw@mail.gmail.com>
Clang is updating to support -Wimplicit-fallthrough on C
https://reviews.llvm.org/D64838. Since clang does not
support the comment version of fallthrough annotations
this update causes an additional 50k warnings. Most
of these warnings (>49k) are duplicates from header files.
This patch is intended to be reverted after the warnings
have been cleaned up.
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
---
Changes v1->v2
* Move code to preexisting ifdef
| 1 +
1 file changed, 1 insertion(+)
--git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index a74ce2e3c33e..95973a1ee999 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -70,5 +70,6 @@ KBUILD_CFLAGS += -Wno-initializer-overrides
KBUILD_CFLAGS += -Wno-format
KBUILD_CFLAGS += -Wno-sign-compare
KBUILD_CFLAGS += -Wno-format-zero-length
+KBUILD_CFLAGS += $(call cc-option,-Wno-implicit-fallthrough)
endif
endif
--
2.23.0.rc1.153.gdeed80330f-goog
next prev parent reply other threads:[~2019-08-15 22:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:20 [PATCH] " Nathan Huckleberry
2019-08-15 20:45 ` Nathan Chancellor
2019-08-15 22:50 ` Nick Desaulniers
2019-08-15 22:58 ` Nathan Huckleberry [this message]
2019-08-15 23:04 ` [PATCH v2] " Nick Desaulniers
2019-08-18 16:43 ` Masahiro Yamada
2019-08-18 18:43 ` Nathan Chancellor
2019-08-19 3:05 ` Masahiro Yamada
2019-08-27 0:41 ` [PATCH] kbuild: Do not enable -Wimplicit-fallthrough for clang for now Nathan Chancellor
2019-08-28 16:20 ` Masahiro Yamada
2019-08-28 16:44 ` Miguel Ojeda
2019-08-28 17:39 ` Nick Desaulniers
2019-08-28 17:44 ` Nick Desaulniers
2019-08-29 17:18 ` Masahiro Yamada
2019-08-28 18:02 ` Gustavo A. R. Silva
2019-08-15 22:59 ` [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang Miguel Ojeda
2019-08-15 23:05 ` Nick Desaulniers
2019-08-15 23:53 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815225844.145726-1-nhuck@google.com \
--to=nhuck@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome