From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0B2C3A5A1 for ; Mon, 19 Aug 2019 17:36:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBBDF22CEA for ; Mon, 19 Aug 2019 17:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566236193; bh=niNnxuYq5RS8Cq49OHBVg8oVS41Q2TCSKl9jTo6o+/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=br5XKSQ/p1adIllQkmtp9xQJBHDcQ5pw+/pYrvFi5jnS30sZgDI3kmNH7/rvb7B8I 9j21ELMJ5uF+pk4w0Rd/DUAGfJzZMh68sypDXertTRN+6RWAKW6YgoKG2Emo8nwln6 /wiog7Vbz8FjpUay2qfptO9JINhL/cWNAIrDBLVo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727980AbfHSRgc (ORCPT ); Mon, 19 Aug 2019 13:36:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:34266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfHSRgc (ORCPT ); Mon, 19 Aug 2019 13:36:32 -0400 Received: from localhost (unknown [122.182.221.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91109204EC; Mon, 19 Aug 2019 17:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566236191; bh=niNnxuYq5RS8Cq49OHBVg8oVS41Q2TCSKl9jTo6o+/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kCv6Y2vy/muGxGBGHKrwkACQuAQLzn5M0YDo88f4hkRB5UoLRVZ+8k3JGcCQoqhO3 9Wpq+ABIz15v3ARPEPG3lNfo/CIn5PTDquLVBQN5AX0JOx6UYAtzfXhjMFCf6VK2U6 k6Y59/CKRHWoqhZXDUhYdDAKVnpYWODuilaJldw4= Date: Mon, 19 Aug 2019 23:05:14 +0530 From: Vinod Koul To: Stephen Boyd Cc: Andy Gross , linux-arm-msm@vger.kernel.org, Bjorn Andersson , sibis@codeaurora.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/22] arm64: dts: qcom: sm8150: Add apss_shared and apps_rsc nodes Message-ID: <20190819173513.GK12733@vkoul-mobl.Dlink> References: <20190814125012.8700-1-vkoul@kernel.org> <20190814125012.8700-18-vkoul@kernel.org> <20190814171235.6BE1721721@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814171235.6BE1721721@mail.kernel.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-08-19, 10:12, Stephen Boyd wrote: > Quoting Vinod Koul (2019-08-14 05:50:07) > > Add apss_shared and apps_rsc node including the rpmhcc child node > > > > Signed-off-by: Vinod Koul > > --- > > Can't this be squashed with the original dtsi file? That makes it a huge blob, imo hard to review. I will still go ahead and squash things in v2, but will still keep logical chunks.. (this can go in original though) > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 30 ++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > index 5c6b103b042b..5258b79676f6 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > @@ -4,6 +4,7 @@ > > > > #include > > #include > > +#include > > But not the rpmh clk bindings? Thats missing will add > > > @@ -272,6 +279,29 @@ > > }; > > }; > > > > + apps_rsc: rsc@18200000 { > > + label = "apps_rsc"; > > + compatible = "qcom,rpmh-rsc"; > > + reg = <0x18200000 0x10000>, > > + <0x18210000 0x10000>, > > + <0x18220000 0x10000>; > > + reg-names = "drv-0", "drv-1", "drv-2"; > > + interrupts = , > > + , > > + ; > > + qcom,tcs-offset = <0xd00>; > > + qcom,drv-id = <2>; > > + qcom,tcs-config = , > > + , > > + , > > + ; > > + > > + rpmhcc: clock-controller { > > + compatible = "qcom,sm8150-rpmh-clk"; > > + #clock-cells = <1>; > > Should take some sort of clocks property to get the board clock for XO? Yes after conversion, I have updated this now -- ~Vinod