From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ADA1C3A589 for ; Tue, 20 Aug 2019 19:29:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEFF422DD3 for ; Tue, 20 Aug 2019 19:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730755AbfHTT32 (ORCPT ); Tue, 20 Aug 2019 15:29:28 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50084 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730273AbfHTT31 (ORCPT ); Tue, 20 Aug 2019 15:29:27 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3AA9F146D389B; Tue, 20 Aug 2019 12:29:26 -0700 (PDT) Date: Tue, 20 Aug 2019 12:29:25 -0700 (PDT) Message-Id: <20190820.122925.1080288470348205792.davem@davemloft.net> To: haiyangz@microsoft.com Cc: sashal@kernel.org, saeedm@mellanox.com, leon@kernel.org, eranbe@mellanox.com, lorenzo.pieralisi@arm.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, kys@microsoft.com, sthemmin@microsoft.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next,v2 2/6] PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface From: David Miller In-Reply-To: <1566242976-108801-3-git-send-email-haiyangz@microsoft.com> References: <1566242976-108801-1-git-send-email-haiyangz@microsoft.com> <1566242976-108801-3-git-send-email-haiyangz@microsoft.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Aug 2019 12:29:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Mon, 19 Aug 2019 19:30:47 +0000 > +static void __exit exit_hv_pci_intf(void) > +{ > + pr_info("unloaded\n"); > +} > + > +static int __init init_hv_pci_intf(void) > +{ > + pr_info("loaded\n"); > + Clogging up the logs with useless messages like this is inappropriate. Please remove these pr_info() calls. Also, all of these symbols should probably be GPL exported.