From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3841EC3A589 for ; Tue, 20 Aug 2019 05:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D444214DA for ; Tue, 20 Aug 2019 05:41:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729168AbfHTFlK (ORCPT ); Tue, 20 Aug 2019 01:41:10 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:37253 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728878AbfHTFlJ (ORCPT ); Tue, 20 Aug 2019 01:41:09 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hzwt8-0002bd-Tl; Tue, 20 Aug 2019 07:40:58 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hzwt7-0001bl-Td; Tue, 20 Aug 2019 07:40:57 +0200 Date: Tue, 20 Aug 2019 07:40:57 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Sam Shih Cc: Rob Herring , Mark Rutland , Matthias Brugger , Thierry Reding , Ryder Lee , John Crispin , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 2/10] pwm: mediatek: droping the check for of_device_get_match_data Message-ID: <20190820054057.xtbhtjm65f6rphcg@pengutronix.de> References: <1566265225-27452-1-git-send-email-sam.shih@mediatek.com> <1566265225-27452-3-git-send-email-sam.shih@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1566265225-27452-3-git-send-email-sam.shih@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Aug 20, 2019 at 09:40:17AM +0800, Sam Shih wrote: > From: sam shih Your Signed-off-by and the mail's From uses capital letters. Can you please make them all match? > This patch drop the check for of_device_get_match_data. > Due to the only way call driver probe is compatible match, > In this case, the platform data should never be NULL. Yeah, all entries in the of_match_table have a .data pointer. Theoretically the driver could be bound by driver.name and then of_device_get_match_data returns NULL. It's still ok to drop this check if you want to, I just want to make sure this possibility is known. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |