From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76945C3A589 for ; Tue, 20 Aug 2019 09:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46E3A2070B for ; Tue, 20 Aug 2019 09:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729508AbfHTJXk (ORCPT ); Tue, 20 Aug 2019 05:23:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:41692 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729210AbfHTJXk (ORCPT ); Tue, 20 Aug 2019 05:23:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BEFE9AE9A; Tue, 20 Aug 2019 09:23:38 +0000 (UTC) Date: Tue, 20 Aug 2019 11:23:37 +0200 From: Petr Mladek To: John Ogness Cc: linux-kernel@vger.kernel.org, Andrea Parri , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Brendan Higgins , Peter Zijlstra , Thomas Gleixner , Linus Torvalds , Greg Kroah-Hartman Subject: Re: [RFC PATCH v4 4/9] printk-rb: initialize new descriptors as invalid Message-ID: <20190820092337.cudkfdfhsu44vlhh@pathway.suse.cz> References: <20190807222634.1723-1-john.ogness@linutronix.de> <20190807222634.1723-5-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807222634.1723-5-john.ogness@linutronix.de> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2019-08-08 00:32:29, John Ogness wrote: > Initialize never-used descriptors as permanently invalid so there The word "permanently" is confusing. It suggests that it will never ever be valid again. I would just remove the word. > is no risk of the descriptor unexpectedly being determined as > valid due to dataring head overflowing/wrapping. Please, provide more details about the solved race. Is it because some reader could have reference to an invalid (reused) descriptor? Can be these invalid descriptors be member of the list? Also it might be worth to mention where is the check that might detect such invalid descriptors and what will be the consequences. Well, this might be clear from the race description. Best Regards, Petr