From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
zhong jiang <zhongjiang@huawei.com>,
<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH 2/2] ASoC: wm8904: implement input mode select as a mux
Date: Tue, 20 Aug 2019 10:50:33 +0000 [thread overview]
Message-ID: <20190820105033.GG10308@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <17f8556414a0e5352dc570fa16d50bd1bc2b4b0a.1566297120.git.mirq-linux@rere.qmqm.pl>
On Tue, Aug 20, 2019 at 12:33:33PM +0200, Michał Mirosław wrote:
> Make '* Capture Mode' a mux. This makes DAPM know that in single-ended
> mode only inverting mux paths need to be enabled.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> +static const struct snd_kcontrol_new rin_mode =
> + SOC_DAPM_ENUM("right Capture Mode", rin_mode_enum);
Minor nit missing a captial on the right here.
Otherwise looks good:
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2019-08-20 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 10:33 [PATCH 1/2] ASoC: wm8904: fix typo in DAPM kcontrol name Michał Mirosław
2019-08-20 10:33 ` [PATCH 2/2] ASoC: wm8904: implement input mode select as a mux Michał Mirosław
2019-08-20 10:50 ` Charles Keepax [this message]
2019-08-20 10:42 ` [PATCH 1/2] ASoC: wm8904: fix typo in DAPM kcontrol name Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820105033.GG10308@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®