From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED48C3A589 for ; Tue, 20 Aug 2019 20:24:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E714322DA7 for ; Tue, 20 Aug 2019 20:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SpoHEF8J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731048AbfHTUYm (ORCPT ); Tue, 20 Aug 2019 16:24:42 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:39182 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731015AbfHTUYj (ORCPT ); Tue, 20 Aug 2019 16:24:39 -0400 Received: by mail-pg1-f195.google.com with SMTP id u17so3855632pgi.6; Tue, 20 Aug 2019 13:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XZ57Pwy9goeqWEy3kYnd3ji6rloSpMikDBJgK5eV04c=; b=SpoHEF8JKQXNsQgtY6MnkDzhzwb9ByhFwBJsASEX0AKWMcxDYzmNOi9pz8Z89Y4trr 2S+g2E6Dsm/DAyYBloM241ZMHz/ysqfS3ZLpZB2kdjLiNexnLqwzLMQO8gl5VSacmYDl zjE7mu4e4017UyHHkLTRBVh1A5aBLT4A5QzalORPfgRTQfQOQTyc72vdWV3W92ck6gj4 Eq1vm/1kEMfQNCMwZYG+QEgU146bE47lU/ORjQE6lM/n4vjsiximZpMd0h5idRGlKZe+ Mwupm6rAQFK4wqQsRWTeXSmcacHkP/J1k/BNWFWaz8T+zgyRx2us60GQPx0fVee30hvo sv8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XZ57Pwy9goeqWEy3kYnd3ji6rloSpMikDBJgK5eV04c=; b=cwQ4mQbooZEGIb+6GjvgU/fkjapGORlbqfBsfBM1plnHdSzbTcxiQlVF4XegHQ5EEa USypBAlOYgXUtmZ2+ekaYWscLrLRHWGCN3pMNXeW0DJ/lPkXBz7r2skynbyeQd1ILpBr zerTdpr/HbcypDxSdNqT0l6nCp5WP5xlHIywV8ppgYlHV88cKSRmsBhvf9htCZDIAfd3 JT5uuRuoHvS9x5eHb8VKk8TeUhuE9XiSLFINQD5SIVwYzaP2BtnIkrClnSyG/FblXS31 L6WdUgobfW13HjnI+x1gqwegq6XFQsaD/1GJfU2TxJ2kWj6hYP9Xk71u2YBwBD4wvKzd PlKA== X-Gm-Message-State: APjAAAVSzYG1lWLGWwkwJ0Dpt0aYax43ZNTovH827D9HvuX2KzGepdgl 0k/a3/hgh40fCuc0dtbJzMX3r4mqRWA= X-Google-Smtp-Source: APXvYqyYyVb8wi394gehiRN2LOM//a0CEXglEwzHvtDHQqME2sxHtR8HGD6ekiKWSBs17JjBs5hxIQ== X-Received: by 2002:a62:1d93:: with SMTP id d141mr13086841pfd.40.1566332678184; Tue, 20 Aug 2019 13:24:38 -0700 (PDT) Received: from localhost.lan (c-67-185-54-80.hsd1.wa.comcast.net. [67.185.54.80]) by smtp.gmail.com with ESMTPSA id k3sm36149846pfg.23.2019.08.20.13.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 13:24:37 -0700 (PDT) From: Andrey Smirnov To: linux-crypto@vger.kernel.org Cc: Andrey Smirnov , Chris Spencer , Cory Tusar , Chris Healy , Lucas Stach , =?UTF-8?q?Horia=20Geant=C4=83?= , Aymen Sghaier , Leonard Crestez , linux-kernel@vger.kernel.org Subject: [PATCH v8 14/16] crypto: caam - always select job ring via RSR on i.MX8MQ Date: Tue, 20 Aug 2019 13:24:00 -0700 Message-Id: <20190820202402.24951-15-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190820202402.24951-1-andrew.smirnov@gmail.com> References: <20190820202402.24951-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Per feedback from NXP tech support the way to use register based service interface on i.MX8MQ is to follow the same set of steps outlined for the case when virtualization is enabled, regardless if it is. Current version of SRM for i.MX8MQ speaks of DECO DID_MS and DECO DID_LS registers, but apparently those are not implemented, so the case when SCFGR[VIRT_EN]=0 should be handled the same as the case when SCFGR[VIRT_EN]=1 Signed-off-by: Andrey Smirnov Cc: Chris Spencer Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: Horia Geantă Cc: Aymen Sghaier Cc: Leonard Crestez Cc: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/crypto/caam/ctrl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c index 4b7f95f64e34..3b18e7e8da1f 100644 --- a/drivers/crypto/caam/ctrl.c +++ b/drivers/crypto/caam/ctrl.c @@ -97,7 +97,12 @@ static inline int run_descriptor_deco0(struct device *ctrldev, u32 *desc, int i; - if (ctrlpriv->virt_en == 1) { + if (ctrlpriv->virt_en == 1 || + /* + * Apparently on i.MX8MQ it doesn't matter if virt_en == 1 + * and the following steps should be performed regardless + */ + of_machine_is_compatible("fsl,imx8mq")) { clrsetbits_32(&ctrl->deco_rsr, 0, DECORSR_JR0); while (!(rd_reg32(&ctrl->deco_rsr) & DECORSR_VALID) && -- 2.21.0